Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Make sure the USB role switch has PLD

Prashant Malani
2024-02-08T18:14:33Z

Hi Heikki,

On Wed, Feb 7, 2024 at 6:59 AM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> The USB role switch does not always have the _PLD (Physical
> Location of Device) in ACPI tables. If it's missing,
> assigning the PLD hash of the port to the switch. That
> should guarantee that the USB Type-C port mapping code is
> always able to find the connection between the two (the port
> and the switch).
>
> Tested-by: Uday Bhat <uday.m.bhat@intel.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/platform/chrome/cros_ec_typec.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 2b2f14a1b711..5c14e8db08b5 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -28,6 +28,7 @@ static int cros_typec_parse_port_props(struct typec_capability *cap,
> struct fwnode_handle *fwnode,
> struct device *dev)
> {
> + struct fwnode_handle *sw_fwnode;
> const char *buf;
> int ret;
>
> @@ -66,6 +67,16 @@ static int cros_typec_parse_port_props(struct typec_capability *cap,
> cap->prefer_role = ret;
> }
>
> + /* Assing the USB role switch the correct pld_crc if it's missing. */
> + sw_fwnode = fwnode_find_reference(fwnode, "usb-role-switch", 0);
> + if (!IS_ERR_OR_NULL(sw_fwnode)) {
> + struct acpi_device *adev = to_acpi_device_node(sw_fwnode);
> +
> + if (adev && !adev->pld_crc)
> + adev->pld_crc = to_acpi_device_node(fwnode)->pld_crc;
> + fwnode_handle_put(sw_fwnode);
Can this be in common Type-C code (maybe typec_register_port())?
It doesn't strike me as ChromeOS specific, but perhaps I am missing something.

Thanks,