Re: [PATCH v3 18/19] power: reset: syscon-poweroff: Move device data into a struct

Andrew Davis
2024-02-12T16:13:34Z

On 2/11/24 5:52 PM, Sebastian Reichel wrote:
> Hi Andrew,
>
> On Thu, Feb 08, 2024 at 11:04:09AM -0600, Andrew Davis wrote:
>> Currently all these device data elements are top level global variables.
>> Move these into a struct. This will be used in the next patch when
>> the global variable usage is removed. Doing this in two steps makes
>> the patches easier to read.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>> drivers/power/reset/syscon-poweroff.c | 36 +++++++++++++++------------
>> 1 file changed, 20 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/power/reset/syscon-poweroff.c b/drivers/power/reset/syscon-poweroff.c
>> index 1b2ce7734260c..4899a019256e8 100644
>> --- a/drivers/power/reset/syscon-poweroff.c
>> +++ b/drivers/power/reset/syscon-poweroff.c
>> @@ -15,15 +15,19 @@
>> #include <linux/pm.h>
>> #include <linux/regmap.h>
>>
>> -static struct regmap *map;
>> -static u32 offset;
>> -static u32 value;
>> -static u32 mask;
>> +struct syscon_poweroff_data {
>> + struct regmap *map;
>> + u32 offset;
>> + u32 value;
>> + u32 mask;
>> +};
>> +
>> +static struct syscon_poweroff_data *data;
>
> This patch is broken without the follow-up patch, since data is
> never allocated. You need to move the memory allocation from the
> next patch to this one.

Ah, yes, seems I meant to make this struct point to a definition
not just a declaration. But just moving the allocation to this
patch seems to make this easier too, will do that, v4 on the way.

Thanks,
Andrew

>
> Greetings,
>
> -- Sebastian