From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 978B22E3E1 for ; Sun, 11 Feb 2024 11:14:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=163.172.96.212 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707650082; cv=none; b=ilkWGG+UV5DX8Eo5UDX9AFd/U84aembV2tGqeNqtXYPtLtgUwmbjlG0Sj1dqiKgPo3oS/6t2rXHySGeGl36wy5V01kXjFCpoyKW4Ag5xWH4wn9K17Il3Ba5t+QsDrtVb5QFBrXAR+k2yZyldBA3x5nN+4wXLPpzfrTFb2+gzsaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707650082; c=relaxed/simple; bh=/NK2rkSevT7xLFFZVOCMtCYxdFNbLxRJj3xSbCjTgr4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t4eGmJiReBaNvQHhVSa7DkC3ZFZmsS50nj6QfsfnwC1RBA+aX5VI/FWlZ6LfQQ2sHe9eYblnlON5LnLZj+QM3WsRMxqKh3w65aYc1WE6X13gz7CK8peKSk3GNVvxkNo4RgBhK+gBjWFs7iPmzHBFtxdmeNHxu32796XEYUN186Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; arc=none smtp.client-ip=163.172.96.212 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 41BBEanQ022162; Sun, 11 Feb 2024 12:14:36 +0100 Date: Sun, 11 Feb 2024 12:14:36 +0100 From: Willy Tarreau To: Rodrigo Campos Cc: Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] tools/nolibc: Fix strlcpy() return code and size usage Message-ID: <20240211111436.GD19364@1wt.eu> References: <20240129141516.198636-1-rodrigo@sdfg.com.ar> <20240129141516.198636-4-rodrigo@sdfg.com.ar> <20240211110814.GB19364@1wt.eu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240211110814.GB19364@1wt.eu> User-Agent: Mutt/1.10.1 (2018-07-13) On Sun, Feb 11, 2024 at 12:08:14PM +0100, Willy Tarreau wrote: > And I think we should explicitly mark > strlen() and the few other ones we're marking weak as noinline so that > the compiler perfers a call there to inlining. So actually the weak argument always prevents inlining from happening so this is not needed (I didn't have it in my previous test). Willy