Re: [PATCH v5 00/35] Fast kernel headers: reduce header dependencies

Geert Uytterhoeven
2024-02-12T13:51:59Z

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

Hi Max,

On Mon, 12 Feb 2024, Max Kellermann wrote:
> This patch set aims to reduce the dependencies between headers, in
> order to have cleaner code and speed up the build. It continues
> previous efforts by other developers.

[...]

Thanks for your series!

On next-20240212 + your series:

m68k/defconfig:

sound/oss/dmasound/dmasound_core.c:1436:8: error: implicit declaration of function ‘get_options’ [-Werror=implicit-function-declaration]
arch/m68k/emu/nfblock.c:45:10: error: implicit declaration of function ‘virt_to_phys’; did you mean ‘virt_to_pfn’? [-Werror=implicit-function-declaration]
arch/m68k/emu/nfblock.c:71:2: error: implicit declaration of function ‘bio_for_each_segment’ [-Werror=implicit-function-declaration]
arch/m68k/emu/nfblock.c:71:39: error: expected ‘;’ before ‘{’ token
fs/notify/fanotify/fanotify_user.c:1760:6: error: implicit declaration of function ‘upper_32_bits’ [-Werror=implicit-function-declaration]
drivers/block/amiflop.c:1954:7: error: implicit declaration of function ‘get_option’; did you mean ‘get_pid’? [-Werror=implicit-function-declaration]
drivers/block/ataflop.c:2163:8: error: implicit declaration of function ‘get_options’ [-Werror=implicit-function-declaration]
drivers/net/Space.c:148:8: error: implicit declaration of function ‘get_options’ [-Werror=implicit-function-declaration]
drivers/scsi/atari_scsi.c:396:2: error: implicit declaration of function ‘get_options’ [-Werror=implicit-function-declaration]
drivers/scsi/NCR5380.c:424:2: error: implicit declaration of function ‘snprintf’ [-Werror=implicit-function-declaration]
drivers/scsi/mac_scsi.c:72:8: error: implicit declaration of function ‘get_options’ [-Werror=implicit-function-declaration]
drivers/zorro/zorro-driver.c:144:6: error: implicit declaration of function ‘add_uevent_var’ [-Werror=implicit-function-declaration]
fs/open.c:1214:19: error: implicit declaration of function ‘upper_32_bits’ [-Werror=implicit-function-declaration]

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds