Re: [PATCH 2/2] firmware: arm_scmi: make scmi_bus_type const

Cristian Marussi
2024-02-13T08:57:56Z

On Sun, Feb 11, 2024 at 12:51:30PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the scmi_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

> drivers/firmware/arm_scmi/bus.c | 2 +-
> drivers/firmware/arm_scmi/common.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c
> index c15928b8c5cc..609a6496c1d4 100644
> --- a/drivers/firmware/arm_scmi/bus.c
> +++ b/drivers/firmware/arm_scmi/bus.c
> @@ -263,7 +263,7 @@ static void scmi_dev_remove(struct device *dev)
> scmi_drv->remove(scmi_dev);
> }
>
> -struct bus_type scmi_bus_type = {
> +const struct bus_type scmi_bus_type = {
> .name = "scmi_protocol",
> .match = scmi_dev_match,
> .probe = scmi_dev_probe,
> diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
> index 00b165d1f502..6affbfdd1dec 100644
> --- a/drivers/firmware/arm_scmi/common.h
> +++ b/drivers/firmware/arm_scmi/common.h
> @@ -141,7 +141,7 @@ scmi_revision_area_get(const struct scmi_protocol_handle *ph);
> void scmi_setup_protocol_implemented(const struct scmi_protocol_handle *ph,
> u8 *prot_imp);
>
> -extern struct bus_type scmi_bus_type;
> +extern const struct bus_type scmi_bus_type;
>
> #define SCMI_BUS_NOTIFY_DEVICE_REQUEST 0
> #define SCMI_BUS_NOTIFY_DEVICE_UNREQUEST 1
>
> --
> 2.43.0
>