Re: [PATCH 1/2] firmware: arm_ffa: Make ffa_bus_type const

Cristian Marussi
2024-02-13T08:57:22Z

On Sun, Feb 11, 2024 at 12:51:29PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the ffa_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian

> ---
> drivers/firmware/arm_ffa/bus.c | 2 +-
> include/linux/arm_ffa.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_ffa/bus.c b/drivers/firmware/arm_ffa/bus.c
> index 1c7940ba5539..2f557e90f2eb 100644
> --- a/drivers/firmware/arm_ffa/bus.c
> +++ b/drivers/firmware/arm_ffa/bus.c
> @@ -105,7 +105,7 @@ static struct attribute *ffa_device_attributes_attrs[] = {
> };
> ATTRIBUTE_GROUPS(ffa_device_attributes);
>
> -struct bus_type ffa_bus_type = {
> +const struct bus_type ffa_bus_type = {
> .name = "arm_ffa",
> .match = ffa_device_match,
> .probe = ffa_device_probe,
> diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h
> index 3d0fde57ba90..c906f666ff5d 100644
> --- a/include/linux/arm_ffa.h
> +++ b/include/linux/arm_ffa.h
> @@ -209,7 +209,7 @@ bool ffa_device_is_valid(struct ffa_device *ffa_dev) { return false; }
> #define module_ffa_driver(__ffa_driver) \
> module_driver(__ffa_driver, ffa_register, ffa_unregister)
>
> -extern struct bus_type ffa_bus_type;
> +extern const struct bus_type ffa_bus_type;
>
> /* FFA transport related */
> struct ffa_partition_info {
>
> --
> 2.43.0
>