From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Prike Liang <Prike.Liang@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Sasha Levin <sashal@kernel.org>,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, Hawking.Zhang@amd.com, lijo.lazar@amd.com,
le.ma@amd.com, James.Zhu@amd.com, shane.xiao@amd.com,
sonny.jiang@amd.com, Likun.Gao@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 6.7 51/58] drm/amdgpu: reset gpu for s3 suspend abort case
Date: Mon, 12 Feb 2024 19:17:57 -0500 [thread overview]
Message-ID: <20240213001837.668862-51-sashal@kernel.org> (raw)
In-Reply-To: <20240213001837.668862-1-sashal@kernel.org>
From: Prike Liang <Prike.Liang@amd.com>
[ Upstream commit 6ef82ac664bb9568ca3956e0d9c9c478e25077ff ]
In the s3 suspend abort case some type of gfx9 power
rail not turn off from FCH side and this will put the
GPU in an unknown power status, so let's reset the gpu
to a known good power state before reinitialize gpu
device.
Signed-off-by: Prike Liang <Prike.Liang@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
index 51342809af03..9b5af3f1383a 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
@@ -1297,10 +1297,32 @@ static int soc15_common_suspend(void *handle)
return soc15_common_hw_fini(adev);
}
+static bool soc15_need_reset_on_resume(struct amdgpu_device *adev)
+{
+ u32 sol_reg;
+
+ sol_reg = RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_81);
+
+ /* Will reset for the following suspend abort cases.
+ * 1) Only reset limit on APU side, dGPU hasn't checked yet.
+ * 2) S3 suspend abort and TOS already launched.
+ */
+ if (adev->flags & AMD_IS_APU && adev->in_s3 &&
+ !adev->suspend_complete &&
+ sol_reg)
+ return true;
+
+ return false;
+}
+
static int soc15_common_resume(void *handle)
{
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
+ if (soc15_need_reset_on_resume(adev)) {
+ dev_info(adev->dev, "S3 suspend abort case, let's reset ASIC.\n");
+ soc15_asic_reset(adev);
+ }
return soc15_common_hw_init(adev);
}
--
2.43.0
next prev parent reply other threads:[~2024-02-13 0:20 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 0:17 [PATCH AUTOSEL 6.7 01/58] fs/ntfs3: Improve alternative boot processing Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 02/58] fs/ntfs3: Modified fix directory element type detection Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 03/58] fs/ntfs3: Improve ntfs_dir_count Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 04/58] fs/ntfs3: Correct hard links updating when dealing with DOS names Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 05/58] fs/ntfs3: Print warning while fixing hard links count Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 06/58] fs/ntfs3: Reduce stack usage Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 07/58] fs/ntfs3: Fix multithreaded stress test Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 08/58] fs/ntfs3: Fix detected field-spanning write (size 8) of single field "le->name" Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 09/58] fs/ntfs3: Correct use bh_read Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 10/58] fs/ntfs3: Add file_modified Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 11/58] fs/ntfs3: Drop suid and sgid bits as a part of fpunch Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 12/58] fs/ntfs3: Implement super_operations::shutdown Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 13/58] fs/ntfs3: ntfs3_forced_shutdown use int instead of bool Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 14/58] fs/ntfs3: Add and fix comments Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 15/58] fs/ntfs3: Add NULL ptr dereference checking at the end of attr_allocate_frame() Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 16/58] fs/ntfs3: Fix c/mtime typo Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 17/58] fs/ntfs3: Disable ATTR_LIST_ENTRY size check Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 18/58] fs/ntfs3: Use kvfree to free memory allocated by kvmalloc Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 19/58] fs/ntfs3: use non-movable memory for ntfs3 MFT buffer cache Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 20/58] fs/ntfs3: Prevent generic message "attempt to access beyond end of device" Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 21/58] fs/ntfs3: Use i_size_read and i_size_write Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 22/58] fs/ntfs3: Correct function is_rst_area_valid Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 23/58] fs/ntfs3: Fixed overflow check in mi_enum_attr() Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 24/58] fs/ntfs3: Update inode->i_size after success write into compressed file Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 25/58] fs/ntfs3: Fix oob in ntfs_listxattr Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 26/58] wifi: mac80211: set station RX-NSS on reconfig Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 27/58] wifi: mac80211: fix driver debugfs for vif type change Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 28/58] wifi: mac80211: initialize SMPS mode correctly Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 29/58] wifi: mac80211: adding missing drv_mgd_complete_tx() call Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 30/58] wifi: mac80211: accept broadcast probe responses on 6 GHz Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 31/58] wifi: iwlwifi: do not announce EPCS support Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 32/58] efi: runtime: Fix potential overflow of soft-reserved region size Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 33/58] efi: Don't add memblocks for soft-reserved memory Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 34/58] hwmon: (coretemp) Enlarge per package core count limit Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 35/58] drm/nouveau: nvkm_gsp_radix3_sg() should use nvkm_gsp_mem_ctor() Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 36/58] scsi: lpfc: Use unsigned type for num_sge Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 37/58] scsi: ufs: core: Fix shift issue in ufshcd_clear_cmd() Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 38/58] scsi: ufs: core: Remove the ufshcd_release() in ufshcd_err_handling_prepare() Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 39/58] LoongArch: Select ARCH_ENABLE_THP_MIGRATION instead of redefining it Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 40/58] LoongArch: Select HAVE_ARCH_SECCOMP to use the common SECCOMP menu Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 41/58] LoongArch: Change acpi_core_pic[NR_CPUS] to acpi_core_pic[MAX_CORE_PIC] Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 42/58] LoongArch: vDSO: Disable UBSAN instrumentation Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 43/58] accel/ivpu: Force snooping for MMU writes Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 44/58] accel/ivpu: Disable d3hot_delay on all NPU generations Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 45/58] accel/ivpu/40xx: Stop passing SKU boot parameters to FW Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 46/58] firewire: core: send bus reset promptly on gap count error Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 47/58] libceph: fail sparse-read if the data length doesn't match Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 48/58] ceph: always check dir caps asynchronously Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 49/58] PCI: dwc: Clean up dw_pcie_ep_raise_msi_irq() alignment Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 50/58] drm/amdgpu: skip to program GFXDEC registers for suspend abort Sasha Levin
2024-02-13 0:17 ` Sasha Levin [this message]
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 52/58] drm/amdgpu: Fix shared buff copy to user Sasha Levin
2024-02-13 0:17 ` [PATCH AUTOSEL 6.7 53/58] drm/amdgpu: Fix HDP flush for VFs on nbio v7.9 Sasha Levin
2024-02-13 0:18 ` [PATCH AUTOSEL 6.7 54/58] smb: client: set correct d_type for reparse points under DFS mounts Sasha Levin
2024-02-13 0:18 ` [PATCH AUTOSEL 6.7 55/58] virtio-blk: Ensure no requests in virtqueues before deleting vqs Sasha Levin
2024-02-13 0:18 ` [PATCH AUTOSEL 6.7 56/58] cifs: change tcon status when need_reconnect is set on it Sasha Levin
2024-02-13 0:18 ` [PATCH AUTOSEL 6.7 57/58] cifs: handle cases where multiple sessions share connection Sasha Levin
2024-02-13 0:18 ` [PATCH AUTOSEL 6.7 58/58] smb3: clarify mount warning Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213001837.668862-51-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Hawking.Zhang@amd.com \
--cc=James.Zhu@amd.com \
--cc=Likun.Gao@amd.com \
--cc=Prike.Liang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=le.ma@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shane.xiao@amd.com \
--cc=sonny.jiang@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox