public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Dan Carpenter" <dan.carpenter@linaro.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Niklas Cassel" <cassel@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Sasha Levin" <sashal@kernel.org>,
	jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
	lpieralisi@kernel.org, kw@linux.com, linux-pci@vger.kernel.org
Subject: [PATCH AUTOSEL 6.6 42/51] PCI: dwc: Clean up dw_pcie_ep_raise_msi_irq() alignment
Date: Mon, 12 Feb 2024 19:20:19 -0500	[thread overview]
Message-ID: <20240213002052.670571-42-sashal@kernel.org> (raw)
In-Reply-To: <20240213002052.670571-1-sashal@kernel.org>

From: Dan Carpenter <dan.carpenter@linaro.org>

[ Upstream commit 67057f48df79a3d73683385f521215146861684b ]

I recently changed the alignment code in dw_pcie_ep_raise_msix_irq().  The
code in dw_pcie_ep_raise_msi_irq() is similar, so update it to match, just
for consistency.  (No effect on runtime, just a cleanup).

Link: https://lore.kernel.org/r/184097e0-c728-42c7-9e8a-556bd33fb612@moroto.mountain
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/pci/controller/dwc/pcie-designware-ep.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
index 8d79dd0e1d60..51f340663260 100644
--- a/drivers/pci/controller/dwc/pcie-designware-ep.c
+++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
@@ -526,9 +526,10 @@ int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 func_no,
 		reg = ep_func->msi_cap + func_offset + PCI_MSI_DATA_32;
 		msg_data = dw_pcie_readw_dbi(pci, reg);
 	}
-	aligned_offset = msg_addr_lower & (epc->mem->window.page_size - 1);
-	msg_addr = ((u64)msg_addr_upper) << 32 |
-			(msg_addr_lower & ~aligned_offset);
+	msg_addr = ((u64)msg_addr_upper) << 32 | msg_addr_lower;
+
+	aligned_offset = msg_addr & (epc->mem->window.page_size - 1);
+	msg_addr = ALIGN_DOWN(msg_addr, epc->mem->window.page_size);
 	ret = dw_pcie_ep_map_addr(epc, func_no, 0, ep->msi_mem_phys, msg_addr,
 				  epc->mem->window.page_size);
 	if (ret)
-- 
2.43.0


  parent reply	other threads:[~2024-02-13  0:21 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13  0:19 [PATCH AUTOSEL 6.6 01/51] fs/ntfs3: Improve alternative boot processing Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 02/51] fs/ntfs3: Modified fix directory element type detection Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 03/51] fs/ntfs3: Improve ntfs_dir_count Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 04/51] fs/ntfs3: Correct hard links updating when dealing with DOS names Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 05/51] fs/ntfs3: Print warning while fixing hard links count Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 06/51] fs/ntfs3: Reduce stack usage Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 07/51] fs/ntfs3: Fix multithreaded stress test Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 08/51] fs/ntfs3: Fix detected field-spanning write (size 8) of single field "le->name" Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 09/51] fs/ntfs3: Add file_modified Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 10/51] fs/ntfs3: Drop suid and sgid bits as a part of fpunch Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 11/51] fs/ntfs3: Implement super_operations::shutdown Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 12/51] fs/ntfs3: ntfs3_forced_shutdown use int instead of bool Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 13/51] fs/ntfs3: Add NULL ptr dereference checking at the end of attr_allocate_frame() Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 14/51] fs/ntfs3: Disable ATTR_LIST_ENTRY size check Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 15/51] fs/ntfs3: Use kvfree to free memory allocated by kvmalloc Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 16/51] fs/ntfs3: use non-movable memory for ntfs3 MFT buffer cache Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 17/51] fs/ntfs3: Prevent generic message "attempt to access beyond end of device" Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 18/51] fs/ntfs3: Use i_size_read and i_size_write Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 19/51] fs/ntfs3: Correct function is_rst_area_valid Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 20/51] fs/ntfs3: Fixed overflow check in mi_enum_attr() Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 21/51] fs/ntfs3: Update inode->i_size after success write into compressed file Sasha Levin
2024-02-13  0:19 ` [PATCH AUTOSEL 6.6 22/51] fs/ntfs3: Fix oob in ntfs_listxattr Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 23/51] wifi: mac80211: set station RX-NSS on reconfig Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 24/51] wifi: mac80211: adding missing drv_mgd_complete_tx() call Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 25/51] wifi: mac80211: accept broadcast probe responses on 6 GHz Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 26/51] wifi: iwlwifi: do not announce EPCS support Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 27/51] efi: runtime: Fix potential overflow of soft-reserved region size Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 28/51] efi: Don't add memblocks for soft-reserved memory Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 29/51] hwmon: (coretemp) Enlarge per package core count limit Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 30/51] scsi: lpfc: Use unsigned type for num_sge Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 31/51] scsi: ufs: core: Fix shift issue in ufshcd_clear_cmd() Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 32/51] scsi: ufs: core: Remove the ufshcd_release() in ufshcd_err_handling_prepare() Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 33/51] LoongArch: Select ARCH_ENABLE_THP_MIGRATION instead of redefining it Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 34/51] LoongArch: Select HAVE_ARCH_SECCOMP to use the common SECCOMP menu Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 35/51] LoongArch: Change acpi_core_pic[NR_CPUS] to acpi_core_pic[MAX_CORE_PIC] Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 36/51] LoongArch: vDSO: Disable UBSAN instrumentation Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 37/51] accel/ivpu: Force snooping for MMU writes Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 38/51] accel/ivpu: Disable d3hot_delay on all NPU generations Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 39/51] accel/ivpu/40xx: Stop passing SKU boot parameters to FW Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 40/51] firewire: core: send bus reset promptly on gap count error Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 41/51] libceph: fail sparse-read if the data length doesn't match Sasha Levin
2024-02-13  0:20 ` Sasha Levin [this message]
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 43/51] drm/amdgpu: skip to program GFXDEC registers for suspend abort Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 44/51] drm/amdgpu: reset gpu for s3 suspend abort case Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 45/51] drm/amdgpu: Fix shared buff copy to user Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 46/51] drm/amdgpu: Fix HDP flush for VFs on nbio v7.9 Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 47/51] smb: client: set correct d_type for reparse points under DFS mounts Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 48/51] virtio-blk: Ensure no requests in virtqueues before deleting vqs Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 49/51] cifs: change tcon status when need_reconnect is set on it Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 50/51] cifs: handle cases where multiple sessions share connection Sasha Levin
2024-02-13  0:20 ` [PATCH AUTOSEL 6.6 51/51] smb3: clarify mount warning Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240213002052.670571-42-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jingoohan1@gmail.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox