From: "Michael S. Tsirkin" <mst@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-kernel@vger.kernel.org, "Zhangjin Wu" <falcon@tinylab.org>,
"Willy Tarreau" <w@1wt.eu>, "Yuan Tan" <tanyuan@tinylab.org>
Subject: Re: [PATCH RFC] misc/pvpanic: add support for normal shutdowns
Date: Tue, 13 Feb 2024 05:41:48 -0500 [thread overview]
Message-ID: <20240213053953-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <2023110407-unselect-uptight-b96d@gregkh>
On Sat, Nov 04, 2023 at 02:05:02PM +0100, Greg Kroah-Hartman wrote:
> > diff --git a/include/uapi/misc/pvpanic.h b/include/uapi/misc/pvpanic.h
> > index 54b7485390d3..82fc618bfbcf 100644
> > --- a/include/uapi/misc/pvpanic.h
> > +++ b/include/uapi/misc/pvpanic.h
> > @@ -5,5 +5,6 @@
> >
> > #define PVPANIC_PANICKED (1 << 0)
> > #define PVPANIC_CRASH_LOADED (1 << 1)
> > +#define PVPANIC_SHUTDOWN (1 << 2)
>
> Why are these in a uapi file?
>
> And if they need to be here, why not use the proper BIT() macro for it?
>
> thanks,
>
> greg k-h
This is interface with hypervisor not userspace, but for PV historically
we do this since the compatibility implications are about the same,
hypervisors (e.g. QEMU) are mostly userspace and so it is convenient for
them to reuse the same machinery to export the headers.
Let's stick to that, cleaner than duplicating everything I think.
--
MST
next prev parent reply other threads:[~2024-02-13 10:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 11:29 [PATCH RFC] misc/pvpanic: add support for normal shutdowns Thomas Weißschuh
2023-11-04 13:05 ` Greg Kroah-Hartman
2023-11-04 13:16 ` Thomas Weißschuh
2023-11-04 13:28 ` Greg Kroah-Hartman
2023-11-04 13:53 ` Thomas Weißschuh
2023-11-04 13:56 ` Willy Tarreau
2023-11-04 17:07 ` Greg Kroah-Hartman
2023-11-04 17:32 ` Thomas Weißschuh
2023-11-05 6:59 ` Willy Tarreau
2024-02-13 10:41 ` Michael S. Tsirkin [this message]
2024-02-21 17:18 ` Thomas Weißschuh
2024-02-28 6:48 ` Thomas Weißschuh
2024-02-28 7:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213053953-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=falcon@tinylab.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=tanyuan@tinylab.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox