From: Christoph Hellwig <hch@lst.de>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Magnus Karlsson <magnus.karlsson@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Alexander Duyck <alexanderduyck@fb.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/7] dma: compile-out DMA sync op calls when not used
Date: Tue, 13 Feb 2024 06:57:07 +0100 [thread overview]
Message-ID: <20240213055707.GB22451@lst.de> (raw)
In-Reply-To: <20240205110426.764393-2-aleksander.lobakin@intel.com>
> +void __dma_sync_single_for_cpu(struct device *dev, dma_addr_t addr,
> + size_t size, enum dma_data_direction dir);
> +void __dma_sync_single_for_device(struct device *dev, dma_addr_t addr,
> + size_t size, enum dma_data_direction dir);
> +void __dma_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg,
> + int nelems, enum dma_data_direction dir);
> +void __dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> + int nelems, enum dma_data_direction dir);
Please stick to the two-tab indentation for continuing prototypes.
The version here is not only much harder to read, but also keeps blowing
up the diffs for current and future changes.
Otherwise this looks good to me.
next prev parent reply other threads:[~2024-02-13 5:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:04 [PATCH net-next v2 0/7] dma: skip calling no-op sync ops when possible Alexander Lobakin
2024-02-05 11:04 ` [PATCH net-next v2 1/7] dma: compile-out DMA sync op calls when not used Alexander Lobakin
2024-02-13 5:57 ` Christoph Hellwig [this message]
2024-02-13 10:14 ` Alexander Lobakin
2024-02-05 11:04 ` [PATCH net-next v2 2/7] dma: avoid redundant calls for sync operations Alexander Lobakin
2024-02-13 6:11 ` Christoph Hellwig
2024-02-13 10:19 ` Alexander Lobakin
2024-02-05 11:04 ` [PATCH net-next v2 3/7] iommu/dma: avoid expensive indirect " Alexander Lobakin
2024-02-05 11:04 ` [PATCH net-next v2 4/7] page_pool: make sure frag API fields don't span between cachelines Alexander Lobakin
2024-02-05 11:04 ` [PATCH net-next v2 5/7] page_pool: don't use driver-set flags field directly Alexander Lobakin
2024-02-05 11:04 ` [PATCH net-next v2 6/7] page_pool: check for DMA sync shortcut earlier Alexander Lobakin
2024-02-05 11:04 ` [PATCH net-next v2 7/7] xsk: use generic DMA sync shortcut instead of a custom one Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213055707.GB22451@lst.de \
--to=hch@lst.de \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox