* [PATCH] leds: ktd2692: add gpiolib dependency
@ 2024-02-13 16:55 Arnd Bergmann
2024-02-15 11:45 ` Daniel Thompson
2024-02-23 15:35 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-02-13 16:55 UTC (permalink / raw)
To: Pavel Machek, Lee Jones
Cc: Arnd Bergmann, Fenglin Wu, Greg Kroah-Hartman, ChiYuan Huang,
Duje Mihanović, Linus Walleij, Daniel Thompson, linux-leds,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The expresswire module requires gpiolib, so anything selecting it
also needs this dependency:
WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
Selected by [y]:
- LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]
Fixes: e59a15af7aa6 ("leds: ktd2692: Convert to use ExpressWire library")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/leds/flash/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
index 01998d71a6a2..809b6d98bb3e 100644
--- a/drivers/leds/flash/Kconfig
+++ b/drivers/leds/flash/Kconfig
@@ -23,6 +23,7 @@ config LEDS_AS3645A
config LEDS_KTD2692
tristate "LED support for Kinetic KTD2692 flash LED controller"
depends on OF
+ depends on GPIOLIB
select LEDS_EXPRESSWIRE
help
This option enables support for Kinetic KTD2692 LED flash connected
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: ktd2692: add gpiolib dependency
2024-02-13 16:55 [PATCH] leds: ktd2692: add gpiolib dependency Arnd Bergmann
@ 2024-02-15 11:45 ` Daniel Thompson
2024-02-23 15:35 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2024-02-15 11:45 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Pavel Machek, Lee Jones, Arnd Bergmann, Fenglin Wu,
Greg Kroah-Hartman, ChiYuan Huang, Duje Mihanović,
Linus Walleij, linux-leds, linux-kernel
On Tue, Feb 13, 2024 at 05:55:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The expresswire module requires gpiolib, so anything selecting it
> also needs this dependency:
>
> WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
> Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
> Selected by [y]:
> - LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]
>
> Fixes: e59a15af7aa6 ("leds: ktd2692: Convert to use ExpressWire library")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] leds: ktd2692: add gpiolib dependency
2024-02-13 16:55 [PATCH] leds: ktd2692: add gpiolib dependency Arnd Bergmann
2024-02-15 11:45 ` Daniel Thompson
@ 2024-02-23 15:35 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2024-02-23 15:35 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Arnd Bergmann
Cc: Arnd Bergmann, Fenglin Wu, Greg Kroah-Hartman, ChiYuan Huang,
Duje Mihanović, Linus Walleij, Daniel Thompson, linux-leds,
linux-kernel
On Tue, 13 Feb 2024 17:55:50 +0100, Arnd Bergmann wrote:
> The expresswire module requires gpiolib, so anything selecting it
> also needs this dependency:
>
> WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
> Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
> Selected by [y]:
> - LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]
>
> [...]
Applied, thanks!
[1/1] leds: ktd2692: add gpiolib dependency
commit: 52380f87d190e1e3f376f6a01d70bca753e81251
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-23 15:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-13 16:55 [PATCH] leds: ktd2692: add gpiolib dependency Arnd Bergmann
2024-02-15 11:45 ` Daniel Thompson
2024-02-23 15:35 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox