Re: [RFC PATCH v2 3/3] gnss: Add driver for AI2 protocol

Andreas Kemnade
2024-02-25T22:17:00Z

Hi Paul,

I have left out one thing to answer.

On Mon, 29 Jan 2024 08:53:27 +0100
Paul Menzel <pmenzel@molgen.mpg.de> wrote:

> > + ret = ai2_send_frame(ai2dev, skb);
> > + if (ret)
> > + return ret;
> > +
> > + msleep(200);
>
> I’d be great if you added a comment, why this long delay is needed.

Well, I am just a bit paranoid, s/msleep/wait_for_completion_timeout/ and
complete() on some ack would probably improve this. I just hesitated to add
something like this until I have the feeling that I do not need to turn the
driver upside-down.

Regards,
Andreas