Re: [PATCH v17 3/6] tracing: Add snapshot refcount

Steven Rostedt
2024-02-19T18:21:12Z

On Mon, 19 Feb 2024 13:17:54 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 13 Feb 2024 11:49:42 +0000
> Vincent Donnefort <vdonnefort@google.com> wrote:
>
> > @@ -9678,7 +9739,9 @@ trace_array_create_systems(const char *name, const char *systems)
> > raw_spin_lock_init(&tr->start_lock);
> >
> > tr->max_lock = (arch_spinlock_t)__ARCH_SPIN_LOCK_UNLOCKED;
> > -
> > +#ifdef CONFIG_TRCER_MAX_TRACE
>
> Oops!
>
> I'll fix this too.
>
>
> > + spinlock_init(&tr->snapshot_trigger_lock);

And this too:

kernel/trace/trace.c:9245:9: error: implicit declaration of function ‘spinlock_init’; did you mean ‘spin_lock_init’? [-Werror=implicit-function-declaration]
9245 | spinlock_init(&tr->snapshot_trigger_lock);
| ^~~~~~~~~~~~~

-- Steve

> > +#endif
> > tr->current_trace = &nop_trace;
> >
> > INIT_LIST_HEAD(&tr->systems);