From: Pranav Prasad <pranavpp@google.com>
To: tglx@linutronix.de, jstultz@google.com, sboyd@kernel.org
Cc: linux-kernel@vger.kernel.org, krossmo@google.com,
Pranav Prasad <pranavpp@google.com>
Subject: [PATCH v3 0/2] alarmtimer: Rework the suspend flow in alarmtimer
Date: Wed, 14 Feb 2024 09:29:00 +0000 [thread overview]
Message-ID: <20240214092902.1908443-1-pranavpp@google.com> (raw)
Hi!
During the driver suspend phase of kernel suspend, alarmtimer's suspend
callback is invoked and it identifies the earliest next wakeup alarm and
programs that into the HW real time clock (RTC). However, there is an
exception to this process. If the next alarm is within the next 2 seconds,
the alarmtimer driver fails to suspend. In this case, a non-trivial amount
of power is spent to freeze and unfreeze all userspace processes and to
suspend and resume a number of devices. In the vast majority of cases, the
imminent alarm that caused the failure was likely already scheduled before
suspend even started. This provides an opportunity to reduce power
consumption if the suspend failure decision is made earlier in the suspend
flow, before the unnecessary extra work is done.
This patch series aims to achieve a kernel suspend flow in which the check
for an imminent alarm is performed early during the suspend prepare phase.
Changes in v3 from v2:
- Reversed the order of patches
- Formatted variable declarations
- Moved the RTC device check out of alarmtimer_get_soonest()
- Reinstated the check for pending alarm in alarmtimer_suspend()
Changes in v2 from v1:
- Moved the pm_wakeup_event call to the PM notifier
- Added a check for RTC device in the PM notifier
Pranav Prasad (2):
alarmtimer: Add PM notifier to check early for imminent alarm
alarmtimer: Create sysfs to make alarm check window configurable
kernel/time/alarmtimer.c | 164 +++++++++++++++++++++++++++++++++------
1 file changed, 140 insertions(+), 24 deletions(-)
--
2.43.0.687.g38aa6559b0-goog
next reply other threads:[~2024-02-14 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 9:29 Pranav Prasad [this message]
2024-02-14 9:29 ` [PATCH v3 1/2] alarmtimer: Add PM notifier to check early for imminent alarm Pranav Prasad
2024-02-14 11:29 ` Thomas Gleixner
2024-02-14 9:29 ` [PATCH v3 2/2] alarmtimer: Create sysfs to make alarm check window configurable Pranav Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214092902.1908443-1-pranavpp@google.com \
--to=pranavpp@google.com \
--cc=jstultz@google.com \
--cc=krossmo@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox