From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: "Ondřej Jirman" <megi@xff.cz>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Andrey Skvortsov <andrej.skvortzov@gmail.com>,
Icenowy Zheng <icenowy@aosc.io>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] dt-bindings: iio: magnetometer: Add DT binding for Voltafield AF8133J
Date: Wed, 14 Feb 2024 16:31:16 +0000 [thread overview]
Message-ID: <20240214163116.000031b5@Huawei.com> (raw)
In-Reply-To: <i2q2vntbhilrpwppzl367ndoetbyd6guyti4t4n7vtg5pwq7bi@tjkio7zpwrfw>
> > > +
> > > + dvdd-supply:
> > > + description: |
> > > + an optional regulator that needs to be on to provide DVDD power (Digital
> > > + IO power, 1.8V~AVDD) to the sensor.
> > > +
> > > + mount-matrix:
> > > + description: an optional 3x3 mounting rotation matrix.
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> >
> > Any power supply that is required for operation should be listed here (even though
> > we can rely on the stub supplies if it isn't in the DT).
> > I used to think this wasn't necessary, so lots of bindings upstream don't yet
> > have it.
>
> By stub supply you mean dummy supply created when the *-supply property is not
> specified in DT? Or something else?
Ah yes. I got the term wrong.
>
> Because DTC_CHK prints a warning if I make the proerty required in bindings and
> not specify it in DT
>
> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2b.dtb: magnetometer@1c: 'avdd-supply' is a required property
> from schema $id: http://devicetree.org/schemas/iio/magnetometer/voltafield,af8133j.yaml#
Provide one, or don't worry about that warning.
Various discussions have taken place on this over time and end
result is bindings should require them to differentiate from power
supplies that are actually optional.
Jonathan
next prev parent reply other threads:[~2024-02-14 16:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 20:51 [PATCH 0/4] Add support for AF8133J magnetometer Ondřej Jirman
2024-02-11 20:51 ` [PATCH 1/4] dt-bindings: vendor-prefix: Add prefix for Voltafield Ondřej Jirman
2024-02-12 7:58 ` Krzysztof Kozlowski
2024-02-11 20:51 ` [PATCH 2/4] dt-bindings: iio: magnetometer: Add DT binding for Voltafield AF8133J Ondřej Jirman
2024-02-11 22:32 ` Rob Herring
2024-02-12 11:47 ` Jonathan Cameron
2024-02-12 13:38 ` Ondřej Jirman
2024-02-14 16:31 ` Jonathan Cameron [this message]
2024-02-14 17:29 ` Conor Dooley
2024-02-14 17:44 ` Ondřej Jirman
2024-02-12 12:05 ` kernel test robot
2024-02-11 20:51 ` [PATCH 3/4] MAINTAINERS: Add an entry for AF8133J driver Ondřej Jirman
2024-02-12 7:59 ` Krzysztof Kozlowski
2024-02-11 20:52 ` [PATCH 4/4] iio: magnetometer: add a driver for Voltafield AF8133J magnetometer Ondřej Jirman
2024-02-12 12:04 ` kernel test robot
2024-02-12 13:02 ` Jonathan Cameron
2024-02-12 15:04 ` Ondřej Jirman
2024-02-14 16:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214163116.000031b5@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andrej.skvortzov@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megi@xff.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox