Re: [PATCH 00/21] drm/i915: remove unused structure members

Jani Nikula
2024-02-16T08:51:27Z

On Fri, 16 Feb 2024, "Jiri Slaby (SUSE)" <jirislaby@kernel.org> wrote:
> this series removes unused i915 structure members as found by
> clang-struct (and manually checked by me).

Thanks Jiri, good stuff!

Acked-by: Jani Nikula <jani.nikula@intel.com>

However, you may have overlooked that drivers/gpu/drm/i915/gvt/ is
maintained separately.

Cc: Zhenyu, Zhi, how do you want the gvt patches in this series handled?

BR,
Jani.

>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
>
> Jiri Slaby (SUSE) (21):
> drm/i915: remove unused intel_dvo_dev_ops hooks
> drm/i915: remove structs intel_vgpu_pipe_format and
> intel_vgpu_fb_format
> drm/i915: remove intel_dsi::{port_bits,hs}
> drm/i915: remove
> intel_gvt_gtt::{mm_alloc_page_table,mm_free_page_table}
> drm/i915: remove intel_gvt_mmio_info::{device,addr_range}
> drm/i915: remove intel_vgpu_workload::{ring_context,restore_inhibit}
> drm/i915: remove intel_vbt_panel_data::edp::initialized
> drm/i915: remove intel_guc::ads_engine_usage_size
> drm/i915: remove i915_drm_client::id
> drm/i915: remove i915_perf_stream::size_exponent
> drm/i915: remove intel_vgpu_gtt::active_ppgtt_mm_bitmap
> drm/i915: remove intel_vgpu_fence::base
> drm/i915: remove intel_vgpu_opregion::mapped
> drm/i915: remove intel_vgpu::intx_trigger
> drm/i915: remove gvt_mmio_block::device
> drm/i915: remove intel_gvt_irq_info::warned
> drm/i915: remove intel_gvt_event_info::policy
> drm/i915: remove intel_gvt_irq::pending_events
> drm/i915: remove execute_cb::signal
> drm/i915: remove i915_vma::obj_hash
> drm/i915: remove intel_memory_region_ops::flags
>
> .../drm/i915/display/intel_display_types.h | 1 -
> drivers/gpu/drm/i915/display/intel_dsi.h | 4 ---
> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 25 -------------------
> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 --
> drivers/gpu/drm/i915/gvt/fb_decoder.h | 11 --------
> drivers/gpu/drm/i915/gvt/gtt.h | 3 ---
> drivers/gpu/drm/i915/gvt/gvt.h | 5 ----
> drivers/gpu/drm/i915/gvt/interrupt.c | 1 -
> drivers/gpu/drm/i915/gvt/interrupt.h | 2 --
> drivers/gpu/drm/i915/gvt/mmio.h | 2 --
> drivers/gpu/drm/i915/gvt/scheduler.h | 2 --
> drivers/gpu/drm/i915/i915_drm_client.h | 2 --
> drivers/gpu/drm/i915/i915_perf_types.h | 1 -
> drivers/gpu/drm/i915/i915_request.c | 1 -
> drivers/gpu/drm/i915/i915_vma_types.h | 1 -
> drivers/gpu/drm/i915/intel_memory_region.h | 2 --
> 16 files changed, 65 deletions(-)

--
Jani Nikula, Intel