From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: jani.nikula@linux.intel.com
Cc: linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: [PATCH 01/21] drm/i915: remove unused intel_dvo_dev_ops hooks
Date: Fri, 16 Feb 2024 07:53:06 +0100 [thread overview]
Message-ID: <20240216065326.6910-2-jirislaby@kernel.org> (raw)
In-Reply-To: <20240216065326.6910-1-jirislaby@kernel.org>
struct intel_dvo_dev_ops's ::create_resources(), ::prepare(),
::commit::, and get_modes() are all unused since their addition in
79e539453b34 (DRM: i915: add mode setting support). Drop all of them.
Found by https://github.com/jirislaby/clang-struct.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
---
drivers/gpu/drm/i915/display/intel_dvo_dev.h | 25 --------------------
1 file changed, 25 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dvo_dev.h b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
index f7e98e1c6470..af7b04539b93 100644
--- a/drivers/gpu/drm/i915/display/intel_dvo_dev.h
+++ b/drivers/gpu/drm/i915/display/intel_dvo_dev.h
@@ -53,12 +53,6 @@ struct intel_dvo_dev_ops {
bool (*init)(struct intel_dvo_device *dvo,
struct i2c_adapter *i2cbus);
- /*
- * Called to allow the output a chance to create properties after the
- * RandR objects have been created.
- */
- void (*create_resources)(struct intel_dvo_device *dvo);
-
/*
* Turn on/off output.
*
@@ -79,16 +73,6 @@ struct intel_dvo_dev_ops {
enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
struct drm_display_mode *mode);
- /*
- * Callback for preparing mode changes on an output
- */
- void (*prepare)(struct intel_dvo_device *dvo);
-
- /*
- * Callback for committing mode changes on an output
- */
- void (*commit)(struct intel_dvo_device *dvo);
-
/*
* Callback for setting up a video mode after fixups have been made.
*
@@ -111,15 +95,6 @@ struct intel_dvo_dev_ops {
*/
bool (*get_hw_state)(struct intel_dvo_device *dev);
- /**
- * Query the device for the modes it provides.
- *
- * This function may also update MonInfo, mm_width, and mm_height.
- *
- * \return singly-linked list of modes or NULL if no modes found.
- */
- struct drm_display_mode *(*get_modes)(struct intel_dvo_device *dvo);
-
/**
* Clean up driver-specific bits of the output
*/
--
2.43.1
next prev parent reply other threads:[~2024-02-16 6:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 6:53 [PATCH 00/21] drm/i915: remove unused structure members Jiri Slaby (SUSE)
2024-02-16 6:53 ` Jiri Slaby (SUSE) [this message]
2024-02-16 6:53 ` [PATCH 02/21] drm/i915: remove structs intel_vgpu_pipe_format and intel_vgpu_fb_format Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 03/21] drm/i915: remove intel_dsi::{port_bits,hs} Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 04/21] drm/i915: remove intel_gvt_gtt::{mm_alloc_page_table,mm_free_page_table} Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 05/21] drm/i915: remove intel_gvt_mmio_info::{device,addr_range} Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 06/21] drm/i915: remove intel_vgpu_workload::{ring_context,restore_inhibit} Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 07/21] drm/i915: remove intel_vbt_panel_data::edp::initialized Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 08/21] drm/i915: remove intel_guc::ads_engine_usage_size Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 09/21] drm/i915: remove i915_drm_client::id Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 10/21] drm/i915: remove i915_perf_stream::size_exponent Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 11/21] drm/i915: remove intel_vgpu_gtt::active_ppgtt_mm_bitmap Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 12/21] drm/i915: remove intel_vgpu_fence::base Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 13/21] drm/i915: remove intel_vgpu_opregion::mapped Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 14/21] drm/i915: remove intel_vgpu::intx_trigger Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 15/21] drm/i915: remove gvt_mmio_block::device Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 16/21] drm/i915: remove intel_gvt_irq_info::warned Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 17/21] drm/i915: remove intel_gvt_event_info::policy Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 18/21] drm/i915: remove intel_gvt_irq::pending_events Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 19/21] drm/i915: remove execute_cb::signal Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 20/21] drm/i915: remove i915_vma::obj_hash Jiri Slaby (SUSE)
2024-02-16 6:53 ` [PATCH 21/21] drm/i915: remove intel_memory_region_ops::flags Jiri Slaby (SUSE)
2024-02-16 8:51 ` [PATCH 00/21] drm/i915: remove unused structure members Jani Nikula
2024-02-16 12:40 ` Zhi Wang
2024-02-20 19:32 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216065326.6910-2-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox