Re: [PATCH v5 14/18] PCI/pwrctl: add a power control driver for WCN7850

Mark Brown
2024-02-22T12:21:46Z

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Thu, Feb 22, 2024 at 10:22:50AM +0100, Bartosz Golaszewski wrote:
> On Wed, Feb 21, 2024 at 12:44 AM Mark Brown <broonie@kernel.org> wrote:

> > Yes, that's the theory - I just question if it actually does something
> > useful in practice. Between regulators getting more and more able to
> > figure out mode switching autonomously based on load monitoring and them
> > getting more efficient it's become very unclear if this actually
> > accomplishes anything, the only usage is the Qualcomm stuff and that's
> > all really unsophisticated and has an air of something that's being
> > cut'n'pasted forwards rather than delivering practical results. There
> > is some value at ultra low loads, but that's more for suspend modes than
> > for actual use.

> Removing it would be out of scope for this series and I don't really
> want to introduce any undefined behavior when doing a big development
> like that. I'll think about it separately.

This is new code?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]