Re: [PATCH v5 03/18] dt-bindings: regulator: describe the PMU module of the QCA6390 package

Mark Brown
2024-02-17T20:43:34Z

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

On Sat, Feb 17, 2024 at 07:32:16PM +0100, Bartosz Golaszewski wrote:
> On Sat, Feb 17, 2024 at 4:48 PM Mark Brown <broonie@kernel.org> wrote:

> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
> > There's no need to resubmit to fix this alone.

> This is quite vague, could you elaborate? I have no idea what is wrong
> with this patch.

The subject line does not look like the subject line for a regulator
patch rendering it almost invisible in my inbox. As you will see if you
follow the above suggestion and look at other commits to the same area
you should see that subject lines should start regulator:.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]