Re: [PATCH v2 0/8] Staging: vc04_services: bcm2835-camera: Fix code style checks

Dan Carpenter
2024-02-19T07:38:46Z

On Sat, Feb 17, 2024 at 10:12:38PM +0100, Moritz C. Weber wrote:
> Resubmit these patches to fix multiple code style checks for better readability, consistency, and to address errors indicated by Gregs patch bot
>
> Moritz C. Weber (8):
> Staging: vc04_services: bcm2835-camera: fix brace code style check
> Staging: vc04_services: bcm2835-camera: fix brace code style check
> Staging: vc04_services: bcm2835-camera: fix brace code style check
> Staging: vc04_services: bcm2835-camera: fix brace code style check
> Staging: vc04_services: bcm2835-camera: fix brace code style check
> Staging: vc04_services: bcm2835-camera: fix blank line style check
> Staging: vc04_services: bcm2835-camera: fix brace code style check
> Staging: vc04_services: bcm2835-camera: fix brace code style check

These are automatically rejected because you sent 8 patches with the
same subject. But really they should just be one patch. In v1 Greg
complained that you were changing a bunch of random stuff. It's not
clear what was going on there because it was random text and there was
no way it would compile.

Was it an AI generated patch or what one earth happened?

Anyway, that was the issue, not that you need to break up the patch line
by line and send each line as a separate patch.

regards,
dan carpenter