From: Guixiong Wei <guixiongwei@gmail.com>
To: gregkh@linuxfoundation.org, jgross@suse.com, boris.ostrovsky@oracle.com
Cc: linux-kernel@vger.kernel.org, Guixiong Wei <weiguixiong@bytedance.com>
Subject: [RESEND RFC] kernel/ksysfs.c: restrict /sys/kernel/notes to root access
Date: Sun, 18 Feb 2024 15:35:01 +0800 [thread overview]
Message-ID: <20240218073501.54555-1-guixiongwei@gmail.com> (raw)
From: Guixiong Wei <weiguixiong@bytedance.com>
Restrict non-privileged user access to /sys/kernel/notes to
avoid security attack.
The non-privileged users have read access to notes. The notes
expose the load address of startup_xen. This address could be
used to bypass KASLR.
For example, the startup_xen is built at 0xffffffff82465180 and
commit_creds is built at 0xffffffff810ad570 which could read from
the /boot/System.map. And the loaded address of startup_xen is
0xffffffffbc265180 which read from /sys/kernel/notes. So the loaded
address of commit_creds is 0xffffffffbc265180 - (0xffffffff82465180
- 0xffffffff810ad570) = 0xffffffffbaead570.
Signed-off-by: Guixiong Wei <weiguixiong@bytedance.com>
---
kernel/ksysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/ksysfs.c b/kernel/ksysfs.c
index b1292a57c2a5..09bc0730239b 100644
--- a/kernel/ksysfs.c
+++ b/kernel/ksysfs.c
@@ -199,7 +199,7 @@ static ssize_t notes_read(struct file *filp, struct kobject *kobj,
static struct bin_attribute notes_attr __ro_after_init = {
.attr = {
.name = "notes",
- .mode = S_IRUGO,
+ .mode = S_IRUSR,
},
.read = ¬es_read,
};
--
2.24.3 (Apple Git-128)
next reply other threads:[~2024-02-18 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 7:35 Guixiong Wei [this message]
2024-02-18 7:47 ` [RESEND RFC] kernel/ksysfs.c: restrict /sys/kernel/notes to root access Greg KH
2024-02-18 9:04 ` Kees Cook
2024-02-19 11:41 ` Guixiong Wei
2024-02-19 13:07 ` Jürgen Groß
2024-02-19 13:21 ` Jann Horn
[not found] <CAJe52t-XxSn2rK+wEg1hNAdsPdq+TO-fj3wEYPK_eBH0d-bsSg@mail.gmail.com>
2024-02-18 7:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240218073501.54555-1-guixiongwei@gmail.com \
--to=guixiongwei@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiguixiong@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox