[PATCH v7 net-next 13/14] net: phy: marvell-88q2xxx: remove duplicated assignment of pma_extable

Dimitri Fedrau
2024-02-18T07:58:38Z

Remove assignment of phydev->pma_extable in mv88q222x_revb0_config_init.
It is already done in mv88q2xxx_config_init, just call
mv88q2xxx_config_init.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
---
drivers/net/phy/marvell-88q2xxx.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/net/phy/marvell-88q2xxx.c b/drivers/net/phy/marvell-88q2xxx.c
index ebcc6b4046fb..75740f378c66 100644
--- a/drivers/net/phy/marvell-88q2xxx.c
+++ b/drivers/net/phy/marvell-88q2xxx.c
@@ -701,12 +701,6 @@ static int mv88q222x_revb0_config_init(struct phy_device *phydev)
return ret;
}

- /* The 88Q2XXX PHYs do have the extended ability register available, but
- * register MDIO_PMA_EXTABLE where they should signalize it does not
- * work according to specification. Therefore, we force it here.
- */
- phydev->pma_extable = MDIO_PMA_EXTABLE_BT1;
-
/* Configure interrupt with default settings, output is driven low for
* active interrupt and high for inactive.
*/
@@ -715,7 +709,7 @@ static int mv88q222x_revb0_config_init(struct phy_device *phydev)
MDIO_MMD_PCS_MV_GPIO_INT_CTRL,
MDIO_MMD_PCS_MV_GPIO_INT_CTRL_TRI_DIS);

- return 0;
+ return mv88q2xxx_config_init(phydev);
}

static int mv88q222x_cable_test_start(struct phy_device *phydev)
--
2.39.2