Re: [PATCH v7] dt-bindings: mtd: spi-nor: add optional interrupts property

Pratyush Yadav
2024-02-20T12:19:20Z

On Mon, Feb 19 2024, Josua Mayer wrote:

> Some spi flash memories have an interrupt signal which can be used for
> signalling on-chip events such as busy status or ecc errors to the host.
>
> Add binding for "interrupts" property so that boards wiring this signal
> may describe the connection.
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> Acked-by: Rob Herring <robh@kernel.org>

Acked-by: Pratyush Yadav <pratyush@kernel.org>

BTW, I don't see any support in SPI NOR for handling these interrupts.
Do you plan to add them in a later patchset? If not, what do you get by
describing them?

> ---
> Changes in v7:
> - split out of original patchset because it should go via mtd tree
> - collected acked-by Rob Herring from v6
> - Link to v6: https://lore.kernel.org/r/20240212-add-am64-som-v6-0-b59edb2bc8c3@solid-run.com
> ---
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 58f0cea160ef..6e3afb42926e 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -52,6 +52,9 @@ properties:
> minItems: 1
> maxItems: 2
>
> + interrupts:
> + maxItems: 1
> +
> m25p,fast-read:
> type: boolean
> description:
>

--
Regards,
Pratyush Yadav