Re: [PATCH 1/2] net/mlx5: pre-initialize sprintf buffers

Yevgeny Kliteynik
2024-02-20T06:58:06Z

On 20-Feb-24 07:50, Zhu Yanjun wrote:
> External email: Use caution opening links or attachments
>
>
> 在 2024/2/19 18:04, Arnd Bergmann 写道:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The debugfs files always in this driver all use an extra round-trip
>> through an snprintf() before getting put into a mlx5dr_dbg_dump_buff()
>> rather than the normal seq_printf().
>>
>> Zhu Yanjun noticed that the buffers are not initialized before being
>> filled or reused and requested them to always be zeroed as a
>> preparation for having more reused between the buffers.
>
> I think that you are the first to find this.

The buffers are not initialized intentionally.
The content is overwritten from the buffer's beginning.
Initializing is not needed as it will only cause perf degradation.

-- YK