From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Yi Liu <yi.l.liu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Kevin Tian <kevin.tian@intel.com>,
Joao Martins <joao.m.martins@oracle.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 10/10] iommu/vt-d: Fix constant-out-of-range warning
Date: Mon, 19 Feb 2024 19:16:01 +0800 [thread overview]
Message-ID: <20240219111601.96405-11-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20240219111601.96405-1-baolu.lu@linux.intel.com>
From: Arnd Bergmann <arnd@arndb.de>
On 32-bit builds, the vt-d driver causes a warning with clang:
drivers/iommu/intel/nested.c:112:13: error: result of comparison of constant 18446744073709551615 with expression of type 'unsigned long' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
112 | if (npages == U64_MAX)
| ~~~~~~ ^ ~~~~~~~
Make the variable a 64-bit type, which matches both the caller and the
use anyway.
Fixes: f6f3721244a8 ("iommu/vt-d: Add iotlb flush for nested domain")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240213095832.455245-1-arnd@kernel.org
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/intel/nested.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/nested.c b/drivers/iommu/intel/nested.c
index d5af5925a31c..a7d68f3d518a 100644
--- a/drivers/iommu/intel/nested.c
+++ b/drivers/iommu/intel/nested.c
@@ -103,7 +103,7 @@ static void nested_flush_dev_iotlb(struct dmar_domain *domain, u64 addr,
}
static void intel_nested_flush_cache(struct dmar_domain *domain, u64 addr,
- unsigned long npages, bool ih)
+ u64 npages, bool ih)
{
struct iommu_domain_info *info;
unsigned int mask;
--
2.34.1
next prev parent reply other threads:[~2024-02-19 11:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 11:15 [PATCH 00/10] [PULL REQUEST] iommu/vt-d: Fixes for v6.8-rc5 Lu Baolu
2024-02-19 11:15 ` [PATCH 01/10] iommu/vt-d: Track nested domains in parent Lu Baolu
2024-02-19 11:15 ` [PATCH 02/10] iommu/vt-d: Add __iommu_flush_iotlb_psi() Lu Baolu
2024-02-19 11:15 ` [PATCH 03/10] iommu/vt-d: Add missing iotlb flush for parent domain Lu Baolu
2024-02-19 11:15 ` [PATCH 04/10] iommu/vt-d: Update iotlb in nested domain attach Lu Baolu
2024-02-19 11:15 ` [PATCH 05/10] iommu/vt-d: Add missing device iotlb flush for parent domain Lu Baolu
2024-02-19 11:15 ` [PATCH 06/10] iommu/vt-d: Remove domain parameter for intel_pasid_setup_dirty_tracking() Lu Baolu
2024-02-19 11:15 ` [PATCH 07/10] iommu/vt-d: Wrap the dirty tracking loop to be a helper Lu Baolu
2024-02-19 11:15 ` [PATCH 08/10] iommu/vt-d: Add missing dirty tracking set for parent domain Lu Baolu
2024-02-19 11:16 ` [PATCH 09/10] iommu/vt-d: Set SSADE when attaching to a parent with dirty tracking Lu Baolu
2024-02-19 11:16 ` Lu Baolu [this message]
2024-02-21 9:29 ` [PATCH 00/10] [PULL REQUEST] iommu/vt-d: Fixes for v6.8-rc5 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219111601.96405-11-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=arnd@arndb.de \
--cc=iommu@lists.linux.dev \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox