From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Jiri Slaby <jirislaby@kernel.org>
Subject: [PATCH v2 2/7] serial: 8250_exar: Use dev_get_drvdata() directly in PM callbacks
Date: Mon, 19 Feb 2024 17:04:58 +0200 [thread overview]
Message-ID: <20240219150627.2101198-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com>
PM callbacks take struct device pointer as a parameter, use
dev_get_drvdata() to retrieve it instead of unneeded double
loop of referencing via pci_get_drvdata(to_pci_dev(dev)).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/serial/8250/8250_exar.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 6580265e1763..28478b9c537b 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -748,8 +748,7 @@ static void exar_pci_remove(struct pci_dev *pcidev)
static int __maybe_unused exar_suspend(struct device *dev)
{
- struct pci_dev *pcidev = to_pci_dev(dev);
- struct exar8250 *priv = pci_get_drvdata(pcidev);
+ struct exar8250 *priv = dev_get_drvdata(dev);
unsigned int i;
for (i = 0; i < priv->nr; i++)
--
2.43.0.rc1.1.gbec44491f096
next prev parent reply other threads:[~2024-02-19 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 15:04 [PATCH v2 0/7] serial: 8250_exar: A few updates to the driver Andy Shevchenko
2024-02-19 15:04 ` [PATCH v2 1/7] serial: 8250_exar: Don't remove GPIO device on suspend Andy Shevchenko
2024-02-19 15:04 ` Andy Shevchenko [this message]
2024-02-19 15:04 ` [PATCH v2 3/7] serial: 8250_exar: Clear interrupts before registering handler Andy Shevchenko
2024-02-19 15:05 ` [PATCH v2 4/7] serial: 8250_exar: Use generic function to set firmware node Andy Shevchenko
2024-02-19 15:05 ` [PATCH v2 5/7] serial: 8250_exar: switch to DEFINE_SIMPLE_DEV_PM_OPS() Andy Shevchenko
2024-02-19 15:05 ` [PATCH v2 6/7] serial: 8250_exar: Use 8250 PCI library to map and assign resources Andy Shevchenko
2024-02-19 15:05 ` [PATCH v2 7/7] serial: 8250_exar: Don't use "proxy" headers Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219150627.2101198-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox