From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1028D69D0D for ; Tue, 20 Feb 2024 14:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437814; cv=none; b=ufcT4PaOYuXjbuF4yYnEgcOWdSYzb9kFhcSHDTkUS7avY0KJ/aRr+/vs5SQ9tACVXQDFZ42Q7wuY/Kutv2jwRpXSCkMxLyM52x1QlzeY2KJXOmU0DV5GX5ijLRQp6Ju6Hm07cnr2Gltv172H99fejAKgM4VuCtp2ZAmGXOfOlz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708437814; c=relaxed/simple; bh=YIgXLQrn14CWmrZfowaGPAblUiVDzjmJHLps35gqblg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KSuQpuIHs8F7NYuWpgBeVXvcVO3JEMZxzzcIxprO8u64wqpcK7Ja09R7vpVX/4F0ZbHy/AptvrZdQwUMDuKH4uJdmdgulCy02YnzksOoF2/4TRBuHynImDe1U+RgG61CokBBCAXEKYUZgR+dPtkgG3ot90S07fkcg5dRD9zjY+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cUjaVRij; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cUjaVRij" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-41271096976so2443865e9.2 for ; Tue, 20 Feb 2024 06:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708437811; x=1709042611; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YIgXLQrn14CWmrZfowaGPAblUiVDzjmJHLps35gqblg=; b=cUjaVRijlpkAuZyhcMvypRAMfKh2/AQw6/z8dfGU7S2aO72BL7k0f6E5CaYlHdrC7i B5CeBHk+oa3ThzoraBFbcmkWTASt2jDG/xQfkEbsNY7/2PpSgo8FDQUwpz1UGr3BLCGi JhClBUX8agY7V1P7/BOgo1JPNBoYWeyRDHbrTYAX8LDPQAX6usUAQ5m8/iFMprUTpf3E wOhSCzJJwSskJXqK2N7ncSWGbe5gZxpCg/L/e4mkOTgnzmmF+K3NHJ/3ouXJ/XTr/KWF r1HTvLz8oUsTsUAUxMiVbfiXxMmV6grWDrCRk6pHLPodfxLEtzHXifwBPX8429XnZ+Gj NbaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708437811; x=1709042611; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YIgXLQrn14CWmrZfowaGPAblUiVDzjmJHLps35gqblg=; b=YVnRR6Z/syDB2o9aYQVtATUTj4GbuzwVDnpoQyOo/NpUB6X7OJ1JT+G3n3CtzUVaHe 3BAD/gYWAmn+mXoQHgXGX9Jg0mYisN2Vfi8rq5qVlpktfrZZd0AIZEboS+gPRicQFZkp aM8Ro3Mi85xtK91Mtekj6mTk5ULkJz5Z0rD1jRKVHgnxLefwjv7jXlGwzlHi6Bom7V5o UvWPP7HM2DZDEtArdXDXZC2lk3LKMp7NgMe6vtpbSZBcObc428DH0DrkenxEnF7DLBRC pP9n4r++e3qfXUzWICsSfYdJqDgcH/K1Qv/Igh0ji4Fdqga4qUsQ7pd/9BKFzjGmwOb/ 3wzA== X-Forwarded-Encrypted: i=1; AJvYcCUqyaMpEhpIv8HrVnahTGOlUsQ764U6wlSGqmSCTVBaBN+AbUX+x/E384wMxZA9HYehxlz4HA9+yL7KTimPHd1B/eHYv87AzNgORFNM X-Gm-Message-State: AOJu0Yza3ryy8OWtk0f8cffCp8+ehx899zwUT6yCN8ozSomb4If7SKxc NdjXC/ktMbvUl8CISF6MFcABlrjnYL3nocQie9cimBENrk6eDwJG0+/pWm8dIC4= X-Google-Smtp-Source: AGHT+IG6vkgZ+8zSvP2/8Ap20RRDORuDhGSZX+BUAp6ws2+0Tc+tQb9sjACW+5haOxYS7Odl/DVhmQ== X-Received: by 2002:a05:600c:1553:b0:40e:d30b:6129 with SMTP id f19-20020a05600c155300b0040ed30b6129mr11941148wmg.13.1708437811534; Tue, 20 Feb 2024 06:03:31 -0800 (PST) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id bj29-20020a0560001e1d00b0033d5c454f03sm4888305wrb.114.2024.02.20.06.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 06:03:31 -0800 (PST) Date: Tue, 20 Feb 2024 14:03:29 +0000 From: Daniel Thompson To: Luca Weiss Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Lee Jones , Jingoo Han , Helge Deller , Andrew Morton , "G.Shark Jeong" , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maximilian Weigand , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] backlight: lm3630a: Don't set bl->props.brightness in get_brightness Message-ID: <20240220140329.GE6716@aspen.lan> References: <20240220-lm3630a-fixups-v1-0-9ca62f7e4a33@z3ntu.xyz> <20240220-lm3630a-fixups-v1-2-9ca62f7e4a33@z3ntu.xyz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220-lm3630a-fixups-v1-2-9ca62f7e4a33@z3ntu.xyz> On Tue, Feb 20, 2024 at 12:11:20AM +0100, Luca Weiss wrote: > There's no need to set bl->props.brightness, the get_brightness function > is just supposed to return the current brightness and not touch the > struct. > > With that done we can also remove the 'goto out' and just return the > value. > > Fixes: 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip") > Signed-off-by: Luca Weiss Reviewed-by: Daniel Thompson Daniel.