* [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller()
@ 2024-02-21 6:20 Dan Carpenter
2024-02-21 7:07 ` Manivannan Sadhasivam
2024-02-21 7:16 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-02-21 6:20 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Alex Elder, Jeffrey Hugo, Erick Archer, mhi, linux-arm-msm,
linux-kernel, kernel-janitors
There is a copy and paste bug here so it checks "ev_ring_el_cache" instead
of "ring_item_cache".
Fixes: 62210a26cd4f ("bus: mhi: ep: Use slab allocator where applicable")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/bus/mhi/ep/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
index 8d7a4102bdb7..f8f674adf1d4 100644
--- a/drivers/bus/mhi/ep/main.c
+++ b/drivers/bus/mhi/ep/main.c
@@ -1497,7 +1497,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
sizeof(struct mhi_ep_ring_item), 0,
0, NULL);
- if (!mhi_cntrl->ev_ring_el_cache) {
+ if (!mhi_cntrl->ring_item_cache) {
ret = -ENOMEM;
goto err_destroy_tre_buf_cache;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller()
2024-02-21 6:20 [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller() Dan Carpenter
@ 2024-02-21 7:07 ` Manivannan Sadhasivam
2024-02-21 7:16 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-21 7:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alex Elder, Jeffrey Hugo, Erick Archer, mhi, linux-arm-msm,
linux-kernel, kernel-janitors
On Wed, Feb 21, 2024 at 09:20:19AM +0300, Dan Carpenter wrote:
> There is a copy and paste bug here so it checks "ev_ring_el_cache" instead
> of "ring_item_cache".
>
> Fixes: 62210a26cd4f ("bus: mhi: ep: Use slab allocator where applicable")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> ---
> drivers/bus/mhi/ep/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> index 8d7a4102bdb7..f8f674adf1d4 100644
> --- a/drivers/bus/mhi/ep/main.c
> +++ b/drivers/bus/mhi/ep/main.c
> @@ -1497,7 +1497,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
> mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
> sizeof(struct mhi_ep_ring_item), 0,
> 0, NULL);
> - if (!mhi_cntrl->ev_ring_el_cache) {
> + if (!mhi_cntrl->ring_item_cache) {
> ret = -ENOMEM;
> goto err_destroy_tre_buf_cache;
> }
> --
> 2.43.0
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller()
2024-02-21 6:20 [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller() Dan Carpenter
2024-02-21 7:07 ` Manivannan Sadhasivam
@ 2024-02-21 7:16 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2024-02-21 7:16 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alex Elder, Jeffrey Hugo, Erick Archer, mhi, linux-arm-msm,
linux-kernel, kernel-janitors
On Wed, Feb 21, 2024 at 09:20:19AM +0300, Dan Carpenter wrote:
> There is a copy and paste bug here so it checks "ev_ring_el_cache" instead
> of "ring_item_cache".
>
> Fixes: 62210a26cd4f ("bus: mhi: ep: Use slab allocator where applicable")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Applied to mhi-next!
- Mani
> ---
> drivers/bus/mhi/ep/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c
> index 8d7a4102bdb7..f8f674adf1d4 100644
> --- a/drivers/bus/mhi/ep/main.c
> +++ b/drivers/bus/mhi/ep/main.c
> @@ -1497,7 +1497,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl,
> mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item",
> sizeof(struct mhi_ep_ring_item), 0,
> 0, NULL);
> - if (!mhi_cntrl->ev_ring_el_cache) {
> + if (!mhi_cntrl->ring_item_cache) {
> ret = -ENOMEM;
> goto err_destroy_tre_buf_cache;
> }
> --
> 2.43.0
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-21 7:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-21 6:20 [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller() Dan Carpenter
2024-02-21 7:07 ` Manivannan Sadhasivam
2024-02-21 7:16 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox