linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
	iommu@lists.linux.dev, Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Petr Tesarik <petr.tesarik1@huawei-partners.com>,
	Dexuan Cui <decui@microsoft.com>,
	Nicolin Chen <nicolinc@nvidia.com>,
	Michael Kelley <mhklinux@outlook.com>
Subject: [PATCH v4 3/5] swiotlb: Honour dma_alloc_coherent() alignment in swiotlb_alloc()
Date: Wed, 21 Feb 2024 11:35:02 +0000	[thread overview]
Message-ID: <20240221113504.7161-4-will@kernel.org> (raw)
In-Reply-To: <20240221113504.7161-1-will@kernel.org>

core-api/dma-api-howto.rst states the following properties of
dma_alloc_coherent():

  | The CPU virtual address and the DMA address are both guaranteed to
  | be aligned to the smallest PAGE_SIZE order which is greater than or
  | equal to the requested size.

However, swiotlb_alloc() passes zero for the 'alloc_align_mask'
parameter of swiotlb_find_slots() and so this property is not upheld.
Instead, allocations larger than a page are aligned to PAGE_SIZE,

Calculate the mask corresponding to the page order suitable for holding
the allocation and pass that to swiotlb_find_slots().

Cc: Christoph Hellwig <hch@lst.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Dexuan Cui <decui@microsoft.com>
Fixes: e81e99bacc9f ("swiotlb: Support aligned swiotlb buffers")
Reviewed-by: Petr Tesarik <petr.tesarik1@huawei-partners.com>
Signed-off-by: Will Deacon <will@kernel.org>
---
 kernel/dma/swiotlb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
index ab7fbb40bc55..c20324fba814 100644
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -1633,12 +1633,14 @@ struct page *swiotlb_alloc(struct device *dev, size_t size)
 	struct io_tlb_mem *mem = dev->dma_io_tlb_mem;
 	struct io_tlb_pool *pool;
 	phys_addr_t tlb_addr;
+	unsigned int align;
 	int index;
 
 	if (!mem)
 		return NULL;
 
-	index = swiotlb_find_slots(dev, 0, size, 0, &pool);
+	align = (1 << (get_order(size) + PAGE_SHIFT)) - 1;
+	index = swiotlb_find_slots(dev, 0, size, align, &pool);
 	if (index == -1)
 		return NULL;
 
-- 
2.44.0.rc0.258.g7320e95886-goog


  parent reply	other threads:[~2024-02-21 11:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 11:34 [PATCH v4 0/5] Fix double allocation in swiotlb_alloc() Will Deacon
2024-02-21 11:35 ` [PATCH v4 1/5] swiotlb: Fix double-allocation of slots due to broken alignment handling Will Deacon
2024-02-21 23:35   ` Michael Kelley
2024-02-23 12:47     ` Will Deacon
2024-02-23 13:36       ` Petr Tesařík
2024-02-23 17:04       ` Michael Kelley
2024-02-27 15:38       ` Christoph Hellwig
2024-02-21 11:35 ` [PATCH v4 2/5] swiotlb: Enforce page alignment in swiotlb_alloc() Will Deacon
2024-02-21 23:36   ` Michael Kelley
2024-02-21 11:35 ` Will Deacon [this message]
2024-02-21 23:36   ` [PATCH v4 3/5] swiotlb: Honour dma_alloc_coherent() " Michael Kelley
2024-02-21 11:35 ` [PATCH v4 4/5] swiotlb: Fix alignment checks when both allocation and DMA masks are present Will Deacon
2024-02-21 23:37   ` Michael Kelley
2024-02-21 11:35 ` [PATCH v4 5/5] iommu/dma: Force swiotlb_max_mapping_size on an untrusted device Will Deacon
2024-02-21 23:39   ` Michael Kelley
2024-02-23 19:58     ` Nicolin Chen
2024-02-23 21:10       ` Michael Kelley
2024-02-25 21:17         ` Michael Kelley
2024-02-26 19:35   ` Robin Murphy
2024-02-26 21:11     ` Michael Kelley
2024-02-27 13:22       ` Robin Murphy
2024-02-27 14:30         ` Michael Kelley
2024-02-27 15:40   ` Christoph Hellwig
2024-02-27 15:53     ` Robin Murphy
2024-02-28 12:05       ` Will Deacon
2024-02-23 11:34 ` [PATCH v4 0/5] Fix double allocation in swiotlb_alloc() Nicolin Chen
2024-02-23 12:25   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240221113504.7161-4-will@kernel.org \
    --to=will@kernel.org \
    --cc=decui@microsoft.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux.dev \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mhklinux@outlook.com \
    --cc=nicolinc@nvidia.com \
    --cc=petr.tesarik1@huawei-partners.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).