From: Hillf Danton <hdanton@sina.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Edward Adam Davis <eadavis@qq.com>,
syzbot+116b65a23bc791ae49a6@syzkaller.appspotmail.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
mchehab@kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] media/cec/core: fix task hung in cec_claim_log_addrs
Date: Thu, 22 Feb 2024 18:43:20 +0800 [thread overview]
Message-ID: <20240222104320.236-1-hdanton@sina.com> (raw)
In-Reply-To: <4fa62e4f-9768-4434-8f7b-24aa3b2a3490@xs4all.nl>
On Wed, 21 Feb 2024 15:38:47 +0100 Hans Verkuil <hverkuil-cisco@xs4all.nl>
> On 21/02/2024 15:20, Edward Adam Davis wrote:
> > After unlocking adap->lock in cec_claim_log_addrs(), cec_claim_log_addrs() may
> > re-enter, causing this issue to occur.
>
> But if it is called again, then it should hit this at the start of the function:
>
> if (WARN_ON(adap->is_configuring || adap->is_configured))
> return;
>
> I'm still not sure what causes the KASAN hung task since I cannot seem to reproduce
> it, and because it is hard for me to find enough time to dig into this.
Likely because of the window for initializing completion more than once [1].
[1] https://lore.kernel.org/lkml/00000000000054a54e0611f1bc01@google.com/
next prev parent reply other threads:[~2024-02-22 10:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 6:13 [syzbot] [media?] INFO: task hung in cec_claim_log_addrs syzbot
2024-02-21 12:29 ` Hillf Danton
2024-02-21 13:53 ` syzbot
2024-02-21 13:13 ` Edward Adam Davis
2024-02-21 14:18 ` syzbot
2024-02-21 14:20 ` [PATCH] media/cec/core: fix " Edward Adam Davis
2024-02-21 14:38 ` Hans Verkuil
2024-02-22 10:43 ` Hillf Danton [this message]
2024-02-22 12:16 ` Hans Verkuil
2024-02-22 10:58 ` Edward Adam Davis
2024-02-22 4:58 ` [syzbot] [media?] INFO: " Hillf Danton
2024-02-22 5:30 ` syzbot
2024-06-23 14:16 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222104320.236-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=eadavis@qq.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=syzbot+116b65a23bc791ae49a6@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox