Re: [RFC][PATCH 03/34] x86/pci: Assume that clflush size is always provided

Borislav Petkov
2024-03-08T08:57:48Z

On Thu, Feb 22, 2024 at 10:39:30AM -0800, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> The early boot code always sets _some_ clflush size. Use that fact

s/clflush/CLFLUSH/g

as it is an insn mnemonic.

> to avoid handling the case where it is not set.
>
> There may have been a time when the Xen PV call in here way too
> early. But it calls get_cpu_address_sizes() before calling here
> now. It should also be safe.
>
> Note: This series will eventually return sane defaults even very
> early in boot. I believe this is safe now, but it becomes *really*
> safe later on.

This should probably be ...

>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> ---

<--- ... here as when applied, "this series" means nothing.

With that:

Reviewed-by: Borislav Petkov (AMD) <bp@alien8.de>

--
Regards/Gruss,
Boris.