* [PATCH v2 0/5] PMBUS Regulator cleanups
@ 2024-02-23 16:21 Conor Dooley
2024-02-23 16:21 ` [PATCH v2 1/5] dt-bindings: hwmon/pmbus: ti,lm25066: document regulators Conor Dooley
` (5 more replies)
0 siblings, 6 replies; 17+ messages in thread
From: Conor Dooley @ 2024-02-23 16:21 UTC (permalink / raw)
To: linux
Cc: conor, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel
From: Conor Dooley <conor.dooley@microchip.com>
A v2 of Guenter's series that changed the name of regulators registered
by PBMUS. The documenation (offical, not bindings) doesn't call the
output Vout0 and there were no bindings for these devices that allowed
regulator child nodes.
Document the regular child nodes for the TI devices and allow regulator
properties for the infineon ones.
Naresh is already working on the tda38640, so there's nothing for that
here DT wise.
Cheers,
Conor.
CC: Jean Delvare <jdelvare@suse.com>
CC: Guenter Roeck <linux@roeck-us.net>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: Liam Girdwood <lgirdwood@gmail.com>
CC: Mark Brown <broonie@kernel.org>
CC: Zev Weiss <zev@bewilderbeest.net>
CC: Patrick Rudolph <patrick.rudolph@9elements.com>
CC: Peter Yin <peteryin.openbmc@gmail.com>
CC: Alexander Stein <alexander.stein@ew.tq-group.com>
CC: linux-hwmon@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Conor Dooley (2):
dt-bindings: hwmon/pmbus: ti,lm25066: document regulators
regulator: dt-bindings: promote infineon buck converters to their own
binding
Guenter Roeck (3):
hwmon: (pmbus/tda38640) Use PMBUS_REGULATOR_ONE to declare regulator
hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator
hwmon: (pmbus/ir38064) Use PMBUS_REGULATOR_ONE to declare regulator
.../bindings/hwmon/pmbus/ti,lm25066.yaml | 12 +++++
.../bindings/regulator/infineon,ir38060.yaml | 46 +++++++++++++++++++
.../devicetree/bindings/trivial-devices.yaml | 8 ----
drivers/hwmon/pmbus/ir38064.c | 2 +-
drivers/hwmon/pmbus/lm25066.c | 2 +-
drivers/hwmon/pmbus/tda38640.c | 2 +-
6 files changed, 61 insertions(+), 11 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
--
2.43.0
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 1/5] dt-bindings: hwmon/pmbus: ti,lm25066: document regulators
2024-02-23 16:21 [PATCH v2 0/5] PMBUS Regulator cleanups Conor Dooley
@ 2024-02-23 16:21 ` Conor Dooley
2024-02-24 11:13 ` Krzysztof Kozlowski
2024-02-23 16:21 ` [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding Conor Dooley
` (4 subsequent siblings)
5 siblings, 1 reply; 17+ messages in thread
From: Conor Dooley @ 2024-02-23 16:21 UTC (permalink / raw)
To: linux
Cc: conor, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel
From: Conor Dooley <conor.dooley@microchip.com>
All devices documented in the lm25066 binding are intended for use with
a regulator, be that for purely monitoring purposes (lm25056) or, for
the other devices, as the controller of that regulator. The binding does
not currently allow regulator child nodes, so add one.
Each of these devices interacts with only a single regulator and
documentation refers to it as "Vout", hence the choice of child node
name.
Acked-by: Zev Weiss <zev@bewilderbeest.net>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml
index da8292bc32f5..4373e9c86e54 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/ti,lm25066.yaml
@@ -34,6 +34,18 @@ properties:
Shunt (sense) resistor value in micro-Ohms
default: 1000
+ regulators:
+ type: object
+
+ properties:
+ vout:
+ $ref: /schemas/regulator/regulator.yaml#
+ type: object
+
+ unevaluatedProperties: false
+
+ additionalProperties: false
+
required:
- compatible
- reg
--
2.43.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
2024-02-23 16:21 [PATCH v2 0/5] PMBUS Regulator cleanups Conor Dooley
2024-02-23 16:21 ` [PATCH v2 1/5] dt-bindings: hwmon/pmbus: ti,lm25066: document regulators Conor Dooley
@ 2024-02-23 16:21 ` Conor Dooley
2024-02-24 11:14 ` Krzysztof Kozlowski
` (2 more replies)
2024-02-23 16:21 ` [PATCH v2 3/5] hwmon: (pmbus/tda38640) Use PMBUS_REGULATOR_ONE to declare regulator Conor Dooley
` (3 subsequent siblings)
5 siblings, 3 replies; 17+ messages in thread
From: Conor Dooley @ 2024-02-23 16:21 UTC (permalink / raw)
To: linux
Cc: conor, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel
From: Conor Dooley <conor.dooley@microchip.com>
These devices are regulators may need to make use of the common
regulator properties, but these are not permitted while only documented
in trivial-devices.yaml
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
.../bindings/regulator/infineon,ir38060.yaml | 46 +++++++++++++++++++
.../devicetree/bindings/trivial-devices.yaml | 8 ----
2 files changed, 46 insertions(+), 8 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
diff --git a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
new file mode 100644
index 000000000000..bb0114f7e13f
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Infineon Buck Regulators with PMBUS interfaces
+
+maintainers:
+ - Not Me.
+
+allOf:
+ - $ref: regulator.yaml#
+
+properties:
+ compatible:
+ enum:
+ - infineon,ir38060
+ - infineon,ir38064
+ - infineon,ir38164
+ - infineon,ir38263
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ regulator@34 {
+ compatible = "infineon,ir38060";
+ reg = <0x34>;
+
+ regulator-min-microvolt = <437500>;
+ regulator-max-microvolt = <1387500>;
+ };
+ };
+
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 9cdd5a534120..e07be7bf8395 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -130,14 +130,6 @@ properties:
- infineon,dps310
# Infineon IR36021 digital POL buck controller
- infineon,ir36021
- # Infineon IR38060 Voltage Regulator
- - infineon,ir38060
- # Infineon IR38064 Voltage Regulator
- - infineon,ir38064
- # Infineon IR38164 Voltage Regulator
- - infineon,ir38164
- # Infineon IR38263 Voltage Regulator
- - infineon,ir38263
# Infineon IRPS5401 Voltage Regulator (PMIC)
- infineon,irps5401
# Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
--
2.43.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 3/5] hwmon: (pmbus/tda38640) Use PMBUS_REGULATOR_ONE to declare regulator
2024-02-23 16:21 [PATCH v2 0/5] PMBUS Regulator cleanups Conor Dooley
2024-02-23 16:21 ` [PATCH v2 1/5] dt-bindings: hwmon/pmbus: ti,lm25066: document regulators Conor Dooley
2024-02-23 16:21 ` [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding Conor Dooley
@ 2024-02-23 16:21 ` Conor Dooley
2024-02-23 16:21 ` [PATCH v2 4/5] hwmon: (pmbus/lm25066) " Conor Dooley
` (2 subsequent siblings)
5 siblings, 0 replies; 17+ messages in thread
From: Conor Dooley @ 2024-02-23 16:21 UTC (permalink / raw)
To: linux
Cc: conor, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel, Naresh Solanki
From: Guenter Roeck <linux@roeck-us.net>
If a chip only provides a single regulator, it should be named 'vout'
and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
that happen.
Cc: Conor Dooley <conor@kernel.org>
Cc: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
drivers/hwmon/pmbus/tda38640.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/pmbus/tda38640.c b/drivers/hwmon/pmbus/tda38640.c
index 09cd114b1736..c31889a036f0 100644
--- a/drivers/hwmon/pmbus/tda38640.c
+++ b/drivers/hwmon/pmbus/tda38640.c
@@ -15,7 +15,7 @@
#include "pmbus.h"
static const struct regulator_desc __maybe_unused tda38640_reg_desc[] = {
- PMBUS_REGULATOR("vout", 0),
+ PMBUS_REGULATOR_ONE("vout"),
};
struct tda38640_data {
--
2.43.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator
2024-02-23 16:21 [PATCH v2 0/5] PMBUS Regulator cleanups Conor Dooley
` (2 preceding siblings ...)
2024-02-23 16:21 ` [PATCH v2 3/5] hwmon: (pmbus/tda38640) Use PMBUS_REGULATOR_ONE to declare regulator Conor Dooley
@ 2024-02-23 16:21 ` Conor Dooley
2024-02-23 23:16 ` Zev Weiss
2024-02-23 16:21 ` [PATCH v2 5/5] hwmon: (pmbus/ir38064) " Conor Dooley
2024-02-24 17:22 ` [PATCH v2 0/5] PMBUS Regulator cleanups Guenter Roeck
5 siblings, 1 reply; 17+ messages in thread
From: Conor Dooley @ 2024-02-23 16:21 UTC (permalink / raw)
To: linux
Cc: conor, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel, Naresh Solanki
From: Guenter Roeck <linux@roeck-us.net>
If a chip only provides a single regulator, it should be named 'vout'
and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
that happen.
Cc: Conor Dooley <conor@kernel.org>
Cc: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Zev Weiss <zev@bewilderbeest.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
drivers/hwmon/pmbus/lm25066.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/pmbus/lm25066.c b/drivers/hwmon/pmbus/lm25066.c
index 3a20df5a43ec..cfffa4cdc0df 100644
--- a/drivers/hwmon/pmbus/lm25066.c
+++ b/drivers/hwmon/pmbus/lm25066.c
@@ -437,7 +437,7 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg,
#if IS_ENABLED(CONFIG_SENSORS_LM25066_REGULATOR)
static const struct regulator_desc lm25066_reg_desc[] = {
- PMBUS_REGULATOR("vout", 0),
+ PMBUS_REGULATOR_ONE("vout"),
};
#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 5/5] hwmon: (pmbus/ir38064) Use PMBUS_REGULATOR_ONE to declare regulator
2024-02-23 16:21 [PATCH v2 0/5] PMBUS Regulator cleanups Conor Dooley
` (3 preceding siblings ...)
2024-02-23 16:21 ` [PATCH v2 4/5] hwmon: (pmbus/lm25066) " Conor Dooley
@ 2024-02-23 16:21 ` Conor Dooley
2024-02-24 17:22 ` [PATCH v2 0/5] PMBUS Regulator cleanups Guenter Roeck
5 siblings, 0 replies; 17+ messages in thread
From: Conor Dooley @ 2024-02-23 16:21 UTC (permalink / raw)
To: linux
Cc: conor, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel, Naresh Solanki
From: Guenter Roeck <linux@roeck-us.net>
If a chip only provides a single regulator, it should be named 'vout'
and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
that happen.
Cc: Conor Dooley <conor@kernel.org>
Cc: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
drivers/hwmon/pmbus/ir38064.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/pmbus/ir38064.c b/drivers/hwmon/pmbus/ir38064.c
index 04185be3fdb6..69e18cb468f6 100644
--- a/drivers/hwmon/pmbus/ir38064.c
+++ b/drivers/hwmon/pmbus/ir38064.c
@@ -22,7 +22,7 @@
#if IS_ENABLED(CONFIG_SENSORS_IR38064_REGULATOR)
static const struct regulator_desc ir38064_reg_desc[] = {
- PMBUS_REGULATOR("vout", 0),
+ PMBUS_REGULATOR_ONE("vout"),
};
#endif /* CONFIG_SENSORS_IR38064_REGULATOR */
--
2.43.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator
2024-02-23 16:21 ` [PATCH v2 4/5] hwmon: (pmbus/lm25066) " Conor Dooley
@ 2024-02-23 23:16 ` Zev Weiss
2024-02-23 23:26 ` Zev Weiss
2024-02-24 19:35 ` Conor Dooley
0 siblings, 2 replies; 17+ messages in thread
From: Zev Weiss @ 2024-02-23 23:16 UTC (permalink / raw)
To: Conor Dooley
Cc: linux, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Patrick Rudolph, Peter Yin, Alexander Stein, linux-hwmon,
devicetree, linux-kernel, Naresh Solanki
On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote:
>From: Guenter Roeck <linux@roeck-us.net>
>
>If a chip only provides a single regulator, it should be named 'vout'
>and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
>that happen.
>
As mentioned on Guenter's v1, this change necessitates a corresponding
update to arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts, which
has a dependency on the name of the regulator. Given (AFAICT) the lack
of any combined dts & driver patches anywhere in the kernel git history
I guess maybe doing both atomically in a single commit might not be
considered kosher, but could it at least be included in the same patch
series?
Thanks,
Zev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator
2024-02-23 23:16 ` Zev Weiss
@ 2024-02-23 23:26 ` Zev Weiss
2024-02-24 0:12 ` Guenter Roeck
2024-02-24 19:35 ` Conor Dooley
1 sibling, 1 reply; 17+ messages in thread
From: Zev Weiss @ 2024-02-23 23:26 UTC (permalink / raw)
To: Conor Dooley
Cc: linux, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Patrick Rudolph, Peter Yin, Alexander Stein, linux-hwmon,
devicetree, linux-kernel, Naresh Solanki
On Fri, Feb 23, 2024 at 03:16:28PM PST, Zev Weiss wrote:
>On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote:
>>From: Guenter Roeck <linux@roeck-us.net>
>>
>>If a chip only provides a single regulator, it should be named 'vout'
>>and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
>>that happen.
>>
>
>Given (AFAICT) the >lack of any combined dts & driver patches anywhere
>in the kernel git history I guess maybe doing both atomically in a
>single commit might not be considered kosher, but could it at least be
>included in the same patch series?
>
Ah, except I realize now I neglected to pass '--full-diff' to 'git log'
when checking that, and after fixing that I see there is in fact some
precedent for commits changing device-trees and driver code together, so
ideally that would be my preference here too.
Thanks,
Zev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator
2024-02-23 23:26 ` Zev Weiss
@ 2024-02-24 0:12 ` Guenter Roeck
0 siblings, 0 replies; 17+ messages in thread
From: Guenter Roeck @ 2024-02-24 0:12 UTC (permalink / raw)
To: Zev Weiss, Conor Dooley
Cc: Conor Dooley, Jean Delvare, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Liam Girdwood, Mark Brown, Patrick Rudolph,
Peter Yin, Alexander Stein, linux-hwmon, devicetree, linux-kernel,
Naresh Solanki
On 2/23/24 15:26, Zev Weiss wrote:
> On Fri, Feb 23, 2024 at 03:16:28PM PST, Zev Weiss wrote:
>> On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote:
>>> From: Guenter Roeck <linux@roeck-us.net>
>>>
>>> If a chip only provides a single regulator, it should be named 'vout'
>>> and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
>>> that happen.
>>>
>
>
>>
>> Given (AFAICT) the >lack of any combined dts & driver patches anywhere in the kernel git history I guess maybe doing both atomically in a single commit might not be considered kosher, but could it at least be included in the same patch series?
>>
>
> Ah, except I realize now I neglected to pass '--full-diff' to 'git log' when checking that, and after fixing that I see there is in fact some precedent for commits changing device-trees and driver code together, so ideally that would be my preference here too.
>
That is not going to happen in the hwmon subsystem unless something slips by.
In a large project like the Linux kernel you'll find precedents for everything,
so citing one is not a valid argument.
As a general rule, I don't apply patches in .dts[i] files through the hwmon
branch at all, not even as part of a patch series. Architecture maintainers
tend to strongly oppose that idea, for the simple reason that it creates
the risk of merge conflicts and thus of bugs during commit windows.
Guenter
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/5] dt-bindings: hwmon/pmbus: ti,lm25066: document regulators
2024-02-23 16:21 ` [PATCH v2 1/5] dt-bindings: hwmon/pmbus: ti,lm25066: document regulators Conor Dooley
@ 2024-02-24 11:13 ` Krzysztof Kozlowski
0 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-24 11:13 UTC (permalink / raw)
To: Conor Dooley, linux
Cc: Conor Dooley, Jean Delvare, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Liam Girdwood, Mark Brown, Zev Weiss,
Patrick Rudolph, Peter Yin, Alexander Stein, linux-hwmon,
devicetree, linux-kernel
On 23/02/2024 17:21, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> All devices documented in the lm25066 binding are intended for use with
> a regulator, be that for purely monitoring purposes (lm25056) or, for
> the other devices, as the controller of that regulator. The binding does
> not currently allow regulator child nodes, so add one.
>
> Each of these devices interacts with only a single regulator and
> documentation refers to it as "Vout", hence the choice of child node
> name.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
2024-02-23 16:21 ` [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding Conor Dooley
@ 2024-02-24 11:14 ` Krzysztof Kozlowski
2024-02-24 18:13 ` Mark Brown
2025-04-10 16:15 ` Geert Uytterhoeven
2 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-24 11:14 UTC (permalink / raw)
To: Conor Dooley, linux
Cc: Conor Dooley, Jean Delvare, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Liam Girdwood, Mark Brown, Zev Weiss,
Patrick Rudolph, Peter Yin, Alexander Stein, linux-hwmon,
devicetree, linux-kernel
On 23/02/2024 17:21, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> These devices are regulators may need to make use of the common
> regulator properties, but these are not permitted while only documented
> in trivial-devices.yaml
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 0/5] PMBUS Regulator cleanups
2024-02-23 16:21 [PATCH v2 0/5] PMBUS Regulator cleanups Conor Dooley
` (4 preceding siblings ...)
2024-02-23 16:21 ` [PATCH v2 5/5] hwmon: (pmbus/ir38064) " Conor Dooley
@ 2024-02-24 17:22 ` Guenter Roeck
5 siblings, 0 replies; 17+ messages in thread
From: Guenter Roeck @ 2024-02-24 17:22 UTC (permalink / raw)
To: Conor Dooley
Cc: Conor Dooley, Jean Delvare, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Liam Girdwood, Mark Brown, Zev Weiss,
Patrick Rudolph, Peter Yin, Alexander Stein, linux-hwmon,
devicetree, linux-kernel
On Fri, Feb 23, 2024 at 04:21:04PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> A v2 of Guenter's series that changed the name of regulators registered
> by PBMUS. The documenation (offical, not bindings) doesn't call the
> output Vout0 and there were no bindings for these devices that allowed
> regulator child nodes.
>
> Document the regular child nodes for the TI devices and allow regulator
> properties for the infineon ones.
>
> Naresh is already working on the tda38640, so there's nothing for that
> here DT wise.
>
Series applied to hwmon-next.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
2024-02-23 16:21 ` [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding Conor Dooley
2024-02-24 11:14 ` Krzysztof Kozlowski
@ 2024-02-24 18:13 ` Mark Brown
2025-04-10 16:15 ` Geert Uytterhoeven
2 siblings, 0 replies; 17+ messages in thread
From: Mark Brown @ 2024-02-24 18:13 UTC (permalink / raw)
To: Conor Dooley
Cc: linux, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Zev Weiss,
Patrick Rudolph, Peter Yin, Alexander Stein, linux-hwmon,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Fri, Feb 23, 2024 at 04:21:06PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> These devices are regulators may need to make use of the common
> regulator properties, but these are not permitted while only documented
> in trivial-devices.yaml
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator
2024-02-23 23:16 ` Zev Weiss
2024-02-23 23:26 ` Zev Weiss
@ 2024-02-24 19:35 ` Conor Dooley
1 sibling, 0 replies; 17+ messages in thread
From: Conor Dooley @ 2024-02-24 19:35 UTC (permalink / raw)
To: Zev Weiss
Cc: linux, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Patrick Rudolph, Peter Yin, Alexander Stein, linux-hwmon,
devicetree, linux-kernel, Naresh Solanki
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Fri, Feb 23, 2024 at 03:16:26PM -0800, Zev Weiss wrote:
> On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote:
> > From: Guenter Roeck <linux@roeck-us.net>
> >
> > If a chip only provides a single regulator, it should be named 'vout'
> > and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
> > that happen.
> >
>
> As mentioned on Guenter's v1, this change necessitates a corresponding
> update to arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts, which has a
> dependency on the name of the regulator. Given (AFAICT) the lack of any
> combined dts & driver patches anywhere in the kernel git history I guess
> maybe doing both atomically in a single commit might not be considered
> kosher, but could it at least be included in the same patch series?
I was gonna do it in isolation if this went ahead, but I see you went
and did it yourself - thanks. As Guenter pointed out later in the
thread, any patch that combines dts changes with drivers or bindings
is something that likely snuck in or was some sort of extenuating
circumstance.
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
2024-02-23 16:21 ` [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding Conor Dooley
2024-02-24 11:14 ` Krzysztof Kozlowski
2024-02-24 18:13 ` Mark Brown
@ 2025-04-10 16:15 ` Geert Uytterhoeven
2025-04-11 16:46 ` Conor Dooley
2 siblings, 1 reply; 17+ messages in thread
From: Geert Uytterhoeven @ 2025-04-10 16:15 UTC (permalink / raw)
To: Conor Dooley
Cc: linux, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel
Hi Conor,
On Fri, 23 Feb 2024 at 17:23, Conor Dooley <conor@kernel.org> wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> These devices are regulators may need to make use of the common
> regulator properties, but these are not permitted while only documented
> in trivial-devices.yaml
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Thanks for your patch, which is now commit bad582f9879812bc
("regulator: dt-bindings: promote infineon buck converters
to their own binding") in v6.9-rc1.
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon Buck Regulators with PMBUS interfaces
> +
> +maintainers:
> + - Not Me.
make dt_binding_check:
Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml:
maintainers:0: 'Not Me.' does not match '@'
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
2025-04-10 16:15 ` Geert Uytterhoeven
@ 2025-04-11 16:46 ` Conor Dooley
2025-04-11 16:57 ` Conor Dooley
0 siblings, 1 reply; 17+ messages in thread
From: Conor Dooley @ 2025-04-11 16:46 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]
On Thu, Apr 10, 2025 at 06:15:24PM +0200, Geert Uytterhoeven wrote:
> Hi Conor,
>
> On Fri, 23 Feb 2024 at 17:23, Conor Dooley <conor@kernel.org> wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> >
> > These devices are regulators may need to make use of the common
> > regulator properties, but these are not permitted while only documented
> > in trivial-devices.yaml
> >
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks for your patch, which is now commit bad582f9879812bc
> ("regulator: dt-bindings: promote infineon buck converters
> to their own binding") in v6.9-rc1.
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Infineon Buck Regulators with PMBUS interfaces
> > +
> > +maintainers:
> > + - Not Me.
>
> make dt_binding_check:
>
> Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml:
> maintainers:0: 'Not Me.' does not match '@'
> from schema $id: http://devicetree.org/meta-schemas/base.yaml#
Yup, and it is still "Not Me.". Shouldn't have been merged in the first
place (or sent tbh), but someone who understands and cares for it should
be here (Not me!)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
2025-04-11 16:46 ` Conor Dooley
@ 2025-04-11 16:57 ` Conor Dooley
0 siblings, 0 replies; 17+ messages in thread
From: Conor Dooley @ 2025-04-11 16:57 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux, Conor Dooley, Jean Delvare, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liam Girdwood, Mark Brown,
Zev Weiss, Patrick Rudolph, Peter Yin, Alexander Stein,
linux-hwmon, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1778 bytes --]
+CC Naresh
On Fri, Apr 11, 2025 at 05:46:38PM +0100, Conor Dooley wrote:
> On Thu, Apr 10, 2025 at 06:15:24PM +0200, Geert Uytterhoeven wrote:
> > Hi Conor,
> >
> > On Fri, 23 Feb 2024 at 17:23, Conor Dooley <conor@kernel.org> wrote:
> > > From: Conor Dooley <conor.dooley@microchip.com>
> > >
> > > These devices are regulators may need to make use of the common
> > > regulator properties, but these are not permitted while only documented
> > > in trivial-devices.yaml
> > >
> > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> >
> > Thanks for your patch, which is now commit bad582f9879812bc
> > ("regulator: dt-bindings: promote infineon buck converters
> > to their own binding") in v6.9-rc1.
> >
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> > > @@ -0,0 +1,46 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Infineon Buck Regulators with PMBUS interfaces
> > > +
> > > +maintainers:
> > > + - Not Me.
> >
> > make dt_binding_check:
> >
> > Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml:
> > maintainers:0: 'Not Me.' does not match '@'
> > from schema $id: http://devicetree.org/meta-schemas/base.yaml#
>
> Yup, and it is still "Not Me.". Shouldn't have been merged in the first
> place (or sent tbh), but someone who understands and cares for it should
> be here (Not me!)
You want to put your name down for this one Naresh, you're the one
making changes to the binding etc so actually know how it works?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2025-04-11 16:57 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-23 16:21 [PATCH v2 0/5] PMBUS Regulator cleanups Conor Dooley
2024-02-23 16:21 ` [PATCH v2 1/5] dt-bindings: hwmon/pmbus: ti,lm25066: document regulators Conor Dooley
2024-02-24 11:13 ` Krzysztof Kozlowski
2024-02-23 16:21 ` [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding Conor Dooley
2024-02-24 11:14 ` Krzysztof Kozlowski
2024-02-24 18:13 ` Mark Brown
2025-04-10 16:15 ` Geert Uytterhoeven
2025-04-11 16:46 ` Conor Dooley
2025-04-11 16:57 ` Conor Dooley
2024-02-23 16:21 ` [PATCH v2 3/5] hwmon: (pmbus/tda38640) Use PMBUS_REGULATOR_ONE to declare regulator Conor Dooley
2024-02-23 16:21 ` [PATCH v2 4/5] hwmon: (pmbus/lm25066) " Conor Dooley
2024-02-23 23:16 ` Zev Weiss
2024-02-23 23:26 ` Zev Weiss
2024-02-24 0:12 ` Guenter Roeck
2024-02-24 19:35 ` Conor Dooley
2024-02-23 16:21 ` [PATCH v2 5/5] hwmon: (pmbus/ir38064) " Conor Dooley
2024-02-24 17:22 ` [PATCH v2 0/5] PMBUS Regulator cleanups Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox