From: Jameson Thies <jthies@google.com>
To: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org
Cc: jthies@google.com, pmalani@chromium.org, bleung@google.com,
abhishekpandit@chromium.org, andersson@kernel.org,
dmitry.baryshkov@linaro.org, fabrice.gasnier@foss.st.com,
gregkh@linuxfoundation.org, hdegoede@redhat.com,
neil.armstrong@linaro.org, rajaram.regupathy@intel.com,
saranya.gopal@intel.com, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] usb: typec: ucsi: Clean up UCSI_CABLE_PROP macros
Date: Fri, 23 Feb 2024 01:03:25 +0000 [thread overview]
Message-ID: <20240223010328.2826774-2-jthies@google.com> (raw)
In-Reply-To: <20240223010328.2826774-1-jthies@google.com>
Clean up UCSI_CABLE_PROP macros by fixing a bitmask shifting error for
plug type and updating the modal support macro for consistent naming.
Fixes: 3cf657f07918 ("usb: typec: ucsi: Remove all bit-fields")
Signed-off-by: Jameson Thies <jthies@google.com>
---
Tested by building v6.6 kernel.
drivers/usb/typec/ucsi/ucsi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
index 7e35ffbe0a6f..469a2baf472e 100644
--- a/drivers/usb/typec/ucsi/ucsi.h
+++ b/drivers/usb/typec/ucsi/ucsi.h
@@ -259,12 +259,12 @@ struct ucsi_cable_property {
#define UCSI_CABLE_PROP_FLAG_VBUS_IN_CABLE BIT(0)
#define UCSI_CABLE_PROP_FLAG_ACTIVE_CABLE BIT(1)
#define UCSI_CABLE_PROP_FLAG_DIRECTIONALITY BIT(2)
-#define UCSI_CABLE_PROP_FLAG_PLUG_TYPE(_f_) ((_f_) & GENMASK(3, 0))
+#define UCSI_CABLE_PROP_FLAG_PLUG_TYPE(_f_) (((_f_) & GENMASK(4, 3)) >> 3)
#define UCSI_CABLE_PROPERTY_PLUG_TYPE_A 0
#define UCSI_CABLE_PROPERTY_PLUG_TYPE_B 1
#define UCSI_CABLE_PROPERTY_PLUG_TYPE_C 2
#define UCSI_CABLE_PROPERTY_PLUG_OTHER 3
-#define UCSI_CABLE_PROP_MODE_SUPPORT BIT(5)
+#define UCSI_CABLE_PROP_FLAG_MODE_SUPPORT BIT(5)
u8 latency;
} __packed;
--
2.44.0.rc0.258.g7320e95886-goog
next prev parent reply other threads:[~2024-02-23 1:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 1:03 [PATCH 0/4] usb: typec: ucsi: Expand SOP/SOP' Discovery Jameson Thies
2024-02-23 1:03 ` Jameson Thies [this message]
2024-02-23 1:24 ` [PATCH 1/4] usb: typec: ucsi: Clean up UCSI_CABLE_PROP macros Benson Leung
2024-02-23 1:43 ` Prashant Malani
2024-02-23 5:37 ` Dmitry Baryshkov
2024-02-26 8:48 ` Heikki Krogerus
2024-02-27 0:29 ` Jameson Thies
2024-02-23 1:03 ` [PATCH 2/4] usb: typec: ucsi: Register cables based on GET_CABLE_PROPERTY Jameson Thies
2024-02-23 1:29 ` Benson Leung
2024-02-23 1:45 ` Prashant Malani
2024-02-23 5:42 ` Dmitry Baryshkov
2024-02-26 9:05 ` Heikki Krogerus
2024-02-23 1:03 ` [PATCH 3/4] usb: typec: ucsi: Register SOP/SOP' Discover Identity Responses Jameson Thies
2024-02-23 1:34 ` Benson Leung
2024-02-23 5:52 ` Dmitry Baryshkov
2024-02-26 9:06 ` Heikki Krogerus
2024-02-26 18:02 ` Prashant Malani
2024-02-27 0:38 ` Jameson Thies
2024-02-23 1:03 ` [PATCH 4/4] usb: typec: ucsi: Register SOP' alternate modes with cable plug Jameson Thies
2024-02-23 1:47 ` Benson Leung
2024-02-23 18:40 ` Prashant Malani
2024-02-26 9:07 ` Heikki Krogerus
2024-02-27 0:44 ` Jameson Thies
2024-02-23 5:34 ` [PATCH 0/4] usb: typec: ucsi: Expand SOP/SOP' Discovery Dmitry Baryshkov
2024-02-27 0:28 ` Jameson Thies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223010328.2826774-2-jthies@google.com \
--to=jthies@google.com \
--cc=abhishekpandit@chromium.org \
--cc=andersson@kernel.org \
--cc=bleung@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pmalani@chromium.org \
--cc=rajaram.regupathy@intel.com \
--cc=saranya.gopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox