From: Sam Ravnborg <sam@ravnborg.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: sparclinux <sparclinux@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andreas Larsson <andreas@gaisler.com>,
"Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: Re: sparc: patch to fix parport_pc build on 32-bit
Date: Fri, 23 Feb 2024 10:34:16 +0100 [thread overview]
Message-ID: <20240223093416.GA2800152@ravnborg.org> (raw)
In-Reply-To: <4c4e2845-c7a8-4d0b-aa4a-7c5e3399b3dc@infradead.org>
Hi Randy/Andreas.
On Thu, Feb 22, 2024 at 09:15:28PM -0800, Randy Dunlap wrote:
> Hi Andreas,
>
> Please pick up this patch from June/2023. I have already replied to
> the patch with:
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>
> and I just rechecked it on linux-next-20240223 to make sure that it
> builds cleanly. It does; however, there is one trivial merge warning:
>
> patching file arch/sparc/include/asm/parport.h
> Hunk #1 succeeded at 20 (offset 1 line).
> Hunk #2 succeeded at 252 (offset 1 line).
>
> The patch:
> https://lore.kernel.org/lkml/alpine.DEB.2.21.2306190121540.14084@angie.orcam.me.uk/
I took a quick look at the patch. It does the minimal to fix the build
but the ebus_dma thing is only used by sparc64 an should not be visible
at all for sparc32.
I think the right fix is to make the current
arch/sparc/include/asm/parport.h sparc64 specific and use
asm-generic/parport.h for sparc32.
Sam
next prev parent reply other threads:[~2024-02-23 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 5:15 sparc: patch to fix parport_pc build on 32-bit Randy Dunlap
2024-02-23 9:34 ` Sam Ravnborg [this message]
2024-02-23 19:39 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223093416.GA2800152@ravnborg.org \
--to=sam@ravnborg.org \
--cc=andreas@gaisler.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=rdunlap@infradead.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox