Re: [PATCH] leds: rgb: Implement per-key keyboard backlight for several TUXEDO devices

kernel test robot
2023-10-12T13:01:10Z

Hi Werner,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-leds/for-leds-next]
[also build test WARNING on linus/master v6.6-rc5 next-20231012]
[cannot apply to pavel-leds/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Werner-Sembach/leds-rgb-Implement-per-key-keyboard-backlight-for-several-TUXEDO-devices/20231012-030206
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link: https://lore.kernel.org/r/20231011190017.1230898-1-wse%40tuxedocomputers.com
patch subject: [PATCH] leds: rgb: Implement per-key keyboard backlight for several TUXEDO devices
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20231012/202310122012.C2mSREZ7-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231012/202310122012.C2mSREZ7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310122012.C2mSREZ7-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/leds/rgb/leds-tuxedo-ite8291.c:44: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Set color for specified [row, column] in row based data structure
drivers/leds/rgb/leds-tuxedo-ite8291.c:79: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Just a generic helper function to reduce boilerplate code
drivers/leds/rgb/leds-tuxedo-ite8291.c:96: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Update brightness of the whole keyboard. Only used for initialization as this doesn't allow per
drivers/leds/rgb/leds-tuxedo-ite8291.c:116: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Update color of a singular row from row_data. This is the smallest unit this device allows to
drivers/leds/rgb/leds-tuxedo-ite8291.c:138: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Write color and brightness to the whole keyboard from row data. Note that per key brightness is

vim +44 drivers/leds/rgb/leds-tuxedo-ite8291.c

42
43 /**
> 44 * Set color for specified [row, column] in row based data structure
45 *
46 * @param row_data Data structure to fill
47 * @param row Row number 0 - 5
48 * @param column Column number 0 - 20
49 * @param red Red brightness 0x00 - 0xff
50 * @param green Green brightness 0x00 - 0xff
51 * @param blue Blue brightness 0x00 - 0xff
52 *
53 * @returns 0 on success, otherwise error
54 */
55 static int leds_tuxedo_ite8291_set_row_data(row_data_t row_data, int row, int column,
56 u8 red, u8 green, u8 blue)
57 {
58 int column_index_red, column_index_green, column_index_blue;
59
60 if (row < 0 || row >= LEDS_TUXEDO_ITE8291_ROWS ||
61 column < 0 || column >= LEDS_TUXEDO_ITE8291_COLUMNS)
62 return -EINVAL;
63
64 column_index_red =
65 LEDS_TUXEDO_ITE8291_ROW_DATA_PADDING + (2 * LEDS_TUXEDO_ITE8291_COLUMNS) + column;
66 column_index_green =
67 LEDS_TUXEDO_ITE8291_ROW_DATA_PADDING + (1 * LEDS_TUXEDO_ITE8291_COLUMNS) + column;
68 column_index_blue =
69 LEDS_TUXEDO_ITE8291_ROW_DATA_PADDING + (0 * LEDS_TUXEDO_ITE8291_COLUMNS) + column;
70
71 row_data[row][column_index_red] = red;
72 row_data[row][column_index_green] = green;
73 row_data[row][column_index_blue] = blue;
74
75 return 0;
76 }
77

--
0-DAY CI Kernel Test Service