From: Lee Jones <lee@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Vadim Pasternak <vadimp@nvidia.com>,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: mlxreg: fix a kernel-doc warning
Date: Fri, 23 Feb 2024 11:01:00 +0000 [thread overview]
Message-ID: <20240223110100.GU10170@google.com> (raw)
In-Reply-To: <20240221060153.3924-1-rdunlap@infradead.org>
On Tue, 20 Feb 2024, Randy Dunlap wrote:
Would you mind being more descriptive in your subject lines please?
It's common for people (me included) to find subject lines a reliable
way to search through Git history and these types of descriptions are
likely to cause duplication.
Thanks.
> Drop one struct description to fix a kernel-doc warning:
>
> drivers/leds/leds-mlxreg.c:42: warning: Excess struct member 'led_data' description in 'mlxreg_led_data'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vadim Pasternak <vadimp@nvidia.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Lee Jones <lee@kernel.org>
> Cc: linux-leds@vger.kernel.org
> ---
> drivers/leds/leds-mlxreg.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff -- a/drivers/leds/leds-mlxreg.c b/drivers/leds/leds-mlxreg.c
> --- a/drivers/leds/leds-mlxreg.c
> +++ b/drivers/leds/leds-mlxreg.c
> @@ -29,7 +29,6 @@
> * @data: led configuration data;
> * @led_cdev: led class data;
> * @base_color: base led color (other colors have constant offset from base);
> - * @led_data: led data;
> * @data_parent: pointer to private device control data of parent;
> * @led_cdev_name: class device name
> */
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-02-23 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 6:01 [PATCH] leds: mlxreg: fix a kernel-doc warning Randy Dunlap
2024-02-23 11:01 ` Lee Jones [this message]
2024-02-23 11:01 ` Lee Jones
2024-02-26 1:49 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223110100.GU10170@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox