From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <linux-iio@vger.kernel.org>, Rob Herring <robh@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
<linux-kernel@vger.kernel.org>,
Julia Lawall <Julia.Lawall@inria.fr>,
Peter Zijlstra <peterz@infradead.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<marek.vasut@gmail.com>
Subject: Re: [PATCH v2 0/4] of: automate of_node_put() - new approach to loops.
Date: Fri, 23 Feb 2024 16:36:02 +0000 [thread overview]
Message-ID: <20240223163602.0000697a@Huawei.com> (raw)
In-Reply-To: <Zdi_ToUofu62s5zT@smile.fi.intel.com>
On Fri, 23 Feb 2024 17:52:46 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Fri, Feb 23, 2024 at 12:44:28PM +0000, Jonathan Cameron wrote:
> > The equivalent device_for_each_child_node_scoped() series for
> > fwnode will be queued up in IIO for the merge window shortly as
> > it has gathered sufficient tags. Hopefully the precdent set there
> > for the approach will reassure people that instantiating the
> > child variable inside the macro definition is the best approach.
> > https://lore.kernel.org/linux-iio/20240217164249.921878-1-jic23@kernel.org/
> >
> > v2: Andy suggested most of the original converted set should move to
> > generic fwnode / property.h handling. Within IIO that was
> > a reasonable observation given we've been trying to move away from
> > firmware specific handling for some time. Patches making that change
> > to appropriate drivers posted.
> > As we discussed there are cases which are not suitable for such
> > conversion and this infrastructure still provides clear benefits
> > for them.
>
> > iio: adc: rcar-gyroadc: use for_each_available_child_node_scoped()
>
> Is this the only one so far? Or do we have more outside of IIO?
>
> I'm fine with the code if OF maintainers think it's useful.
> My concern is to make as many as possible drivers to be converted to
> use fwnode instead of OF one.
>
Julia wrote a coccinelle script
__free() cases
https://lore.kernel.org/all/alpine.DEB.2.22.394.2401291455430.8649@hadrien/
next prev parent reply other threads:[~2024-02-23 16:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 12:44 [PATCH v2 0/4] of: automate of_node_put() - new approach to loops Jonathan Cameron
2024-02-23 12:44 ` [PATCH v2 1/4] of: Add cleanup.h based auto release via __free(device_node) markings Jonathan Cameron
2024-02-23 12:44 ` [PATCH v2 2/4] of: Introduce for_each_*_child_of_node_scoped() to automate of_node_put() handling Jonathan Cameron
2024-02-23 12:44 ` [PATCH v2 3/4] of: unittest: Use for_each_child_of_node_scoped() Jonathan Cameron
2024-02-23 12:44 ` [PATCH v2 4/4] iio: adc: rcar-gyroadc: use for_each_available_child_node_scoped() Jonathan Cameron
2024-02-23 15:52 ` [PATCH v2 0/4] of: automate of_node_put() - new approach to loops Andy Shevchenko
2024-02-23 16:36 ` Jonathan Cameron [this message]
2024-02-23 16:38 ` Julia Lawall
2024-02-23 17:12 ` Jonathan Cameron
2024-02-23 16:42 ` Jonathan Cameron
2024-02-25 14:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223163602.0000697a@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Julia.Lawall@inria.fr \
--cc=andriy.shevchenko@linux.intel.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox