public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>
Subject: [PATCH v1 5/6] mfd: kempld: Drop duplicate NULL check in ->exit()
Date: Fri, 23 Feb 2024 21:49:54 +0200	[thread overview]
Message-ID: <20240223195113.880121-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com>

Since platform_device_unregister() is NULL-aware, we don't need
to duplicate this check. Remove it and fold the rest of the code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/kempld-core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c
index c3bc61dcd098..30b8408c094e 100644
--- a/drivers/mfd/kempld-core.c
+++ b/drivers/mfd/kempld-core.c
@@ -895,9 +895,7 @@ static int __init kempld_init(void)
 
 static void __exit kempld_exit(void)
 {
-	if (kempld_pdev)
-		platform_device_unregister(kempld_pdev);
-
+	platform_device_unregister(kempld_pdev);
 	platform_driver_unregister(&kempld_driver);
 }
 
-- 
2.43.0.rc1.1.gbec44491f096


  parent reply	other threads:[~2024-02-23 19:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 19:49 [PATCH v1 0/6] mfd: kempld: A few cleanups Andy Shevchenko
2024-02-23 19:49 ` [PATCH v1 1/6] mfd: kempld: Replace ACPI code with agnostic one Andy Shevchenko
2024-02-23 19:49 ` [PATCH v1 2/6] mfd: kempld: Use device core to create driver-specific device attributes Andy Shevchenko
2024-02-23 19:49 ` [PATCH v1 3/6] mfd: kempld: Simplify device registration Andy Shevchenko
2024-02-23 19:49 ` [PATCH v1 4/6] mfd: kempld: Use PLATFORM_DEVID_NONE instead of -1 Andy Shevchenko
2024-02-23 19:49 ` Andy Shevchenko [this message]
2024-02-23 19:49 ` [PATCH v1 6/6] mfd: kempld: Remove dead code Andy Shevchenko
2024-04-02 15:31 ` [PATCH v1 0/6] mfd: kempld: A few cleanups Andy Shevchenko
2024-04-11  9:29   ` Lee Jones
2024-04-11 10:20     ` Andy Shevchenko
2024-04-11 10:56       ` Lee Jones
2024-04-11 12:12         ` Andy Shevchenko
2024-04-11 10:10 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240223195113.880121-6-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox