From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v3 03/10] crypto: ecdsa - Extend res.x mod n calculation for NIST P521
Date: Fri, 23 Feb 2024 15:41:42 -0500 [thread overview]
Message-ID: <20240223204149.4055630-4-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20240223204149.4055630-1-stefanb@linux.ibm.com>
res.x has been calculated by ecc_point_mult_shamir, which uses
'mod curve_prime'. The curve_prime 'p' is typically larger than the
curve_order 'n' and therefore it is possible that p > res.x >= n.
If res.x >= n then res.x mod n can be calculated by iteratively sub-
tracting n from res.x until n > res.x. For NIST P192/256/384 this can be
done in a single subtraction. This can also be done in a single
subtraction for NIST P521.
The mathematical reason why a single subtraction is sufficient is
due to the values of 'p' and 'n' of the NIST curves where the following
holds true:
note: max(res.x) = p - 1
max(res.x) - n < n
p - 1 - n < n
p - 1 < 2n => true for the NIST curves
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
crypto/ecdsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/ecdsa.c b/crypto/ecdsa.c
index 64e1e69d53ba..1814f009f971 100644
--- a/crypto/ecdsa.c
+++ b/crypto/ecdsa.c
@@ -122,7 +122,7 @@ static int _ecdsa_verify(struct ecc_ctx *ctx, const u64 *hash, const u64 *r, con
/* res.x = res.x mod n (if res.x > order) */
if (unlikely(vli_cmp(res.x, curve->n, ndigits) == 1))
- /* faster alternative for NIST p384, p256 & p192 */
+ /* faster alternative for NIST p521, p384, p256 & p192 */
vli_sub(res.x, res.x, curve->n, ndigits);
if (!vli_cmp(res.x, r, ndigits))
--
2.43.0
next prev parent reply other threads:[~2024-02-23 20:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 20:41 [PATCH v3 00/10] Add support for NIST P521 to ecdsa Stefan Berger
2024-02-23 20:41 ` [PATCH v3 01/10] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-02-29 9:11 ` Lukas Wunner
2024-02-29 14:57 ` Stefan Berger
2024-02-29 16:48 ` Lukas Wunner
2024-02-29 17:20 ` Stefan Berger
2024-03-01 20:26 ` Jarkko Sakkinen
2024-03-01 20:48 ` Stefan Berger
2024-03-01 20:51 ` Jarkko Sakkinen
2024-03-02 14:00 ` Lukas Wunner
2024-03-02 21:19 ` Stefan Berger
2024-03-02 21:36 ` Lukas Wunner
2024-03-02 21:55 ` Jarkko Sakkinen
2024-02-23 20:41 ` [PATCH v3 02/10] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-02-29 9:16 ` Lukas Wunner
2024-02-29 20:28 ` Stefan Berger
2024-02-23 20:41 ` Stefan Berger [this message]
2024-02-23 20:41 ` [PATCH v3 04/10] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-02-23 20:41 ` [PATCH v3 05/10] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-02-23 20:41 ` [PATCH v3 06/10] crypte: ecc - Implement ecc_curve_get_nbits to get number of bits Stefan Berger
2024-02-27 20:15 ` Lukas Wunner
2024-02-29 20:29 ` Stefan Berger
2024-02-23 20:41 ` [PATCH v3 07/10] crypto: ecc - Use ecc_get_curve_nbits to get number of bits for NIST P521 Stefan Berger
2024-02-23 20:41 ` [PATCH v3 08/10] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-02-23 20:41 ` [PATCH v3 09/10] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-02-23 20:41 ` [PATCH v3 10/10] x509: Add OID for NIST P521 and extend parser for it Stefan Berger
2024-02-29 9:34 ` [PATCH v3 00/10] Add support for NIST P521 to ecdsa Lukas Wunner
2024-02-29 18:45 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223204149.4055630-4-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saulo.alessandre@tse.jus.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox