From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"David E . Box" <david.e.box@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Tasev Nikola" <tasev.stefanoska@skynet.be>,
"Mark Enriquez" <enriquezmark36@gmail.com>,
"Thomas Witt" <kernel@witt.link>,
"Werner Sembach" <wse@tuxedocomputers.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Ricky Wu" <ricky_wu@realtek.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: [PATCH v7 0/5] PCI/ASPM: Save/restore L1 PM Substates for suspend/resume
Date: Fri, 23 Feb 2024 14:58:46 -0600 [thread overview]
Message-ID: <20240223205851.114931-1-helgaas@kernel.org> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
This is some rework of David's series to preserve ASPM L1 substate
configuration across suspend/resume.
We've had several attempts to make this work:
(unlabeled): https://lore.kernel.org/r/20240128233212.1139663-1-david.e.box@linux.intel.com
v5: https://lore.kernel.org/r/20231221011250.191599-1-david.e.box@linux.intel.com
v4: https://lore.kernel.org/all/20231002070044.2299644-1-mika.westerberg@linux.intel.com/
v3: https://lore.kernel.org/linux-pci/20230925074636.2893747-1-mika.westerberg@linux.intel.com/
v2: https://lore.kernel.org/linux-pci/20230911073352.3472918-1-mika.westerberg@linux.intel.com/
v1: https://lore.kernel.org/linux-pci/20230627062442.54008-1-mika.westerberg@linux.intel.com/
The most recent posting is the unlabeled one mentioned above, and I'm
calling it v6 and this rework v7.
Changes since the unlabeled v6:
- Rename pci_save_aspm_state() to pci_save_aspm_l1ss_state() (this
is the reason for opening this again, because Vidya's patch [1]
had to do some incidental renaming).
- Rename pcie_restore_aspm_l1ss() to pci_restore_aspm_l1ss_state()
to match.
- Move the PCI_EXP_LNKCTL_ASPMC from pci_restore_aspm_state() to
pci_restore_pcie_state() so both writes are in the same place.
- Rename pci_aspm_get_l1ss() to pci_configure_aspm_l1ss() and add
the save_buffer there as well.
- Split [1/5] into two patches: move pci_configure_ltr() and
pci_bridge_reconfigure_ltr() to aspm.c, and build aspm.c
unconditionally.
- Squash [2/5] and [3/5] since [2/5] didn't add any functionality
itself so they seem like a single logical change.
[1] https://lore.kernel.org/r/20230125133830.20620-1-vidyas@nvidia.com
David E. Box (5):
PCI/ASPM: Move pci_configure_ltr() to aspm.c
PCI/ASPM: Always build aspm.c
PCI/ASPM: Move pci_save_ltr_state() to aspm.c
PCI/ASPM: Save L1 PM Substates Capability for suspend/resume
PCI/ASPM: Call pci_save_ltr_state() from pci_save_pcie_state()
drivers/pci/pci.c | 89 ++++------------
drivers/pci/pci.h | 13 ++-
drivers/pci/pcie/Makefile | 2 +-
drivers/pci/pcie/aspm.c | 215 ++++++++++++++++++++++++++++++++++++++
drivers/pci/probe.c | 62 +----------
include/linux/pci.h | 2 +-
6 files changed, 252 insertions(+), 131 deletions(-)
--
2.34.1
next reply other threads:[~2024-02-23 20:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 20:58 Bjorn Helgaas [this message]
2024-02-23 20:58 ` [PATCH v7 1/5] PCI/ASPM: Move pci_configure_ltr() to aspm.c Bjorn Helgaas
2024-02-23 20:58 ` [PATCH v7 2/5] PCI/ASPM: Always build aspm.c Bjorn Helgaas
2024-02-26 6:44 ` Kuppuswamy Sathyanarayanan
2024-02-26 21:04 ` Bjorn Helgaas
2024-02-23 20:58 ` [PATCH v7 3/5] PCI/ASPM: Move pci_save_ltr_state() to aspm.c Bjorn Helgaas
2024-02-23 20:58 ` [PATCH v7 4/5] PCI/ASPM: Save L1 PM Substates Capability for suspend/resume Bjorn Helgaas
2024-02-23 21:37 ` Bjorn Helgaas
2024-02-23 20:58 ` [PATCH v7 5/5] PCI/ASPM: Call pci_save_ltr_state() from pci_save_pcie_state() Bjorn Helgaas
2024-03-05 21:46 ` [PATCH v7 0/5] PCI/ASPM: Save/restore L1 PM Substates for suspend/resume Bjorn Helgaas
2024-03-07 22:25 ` Bjorn Helgaas
2024-03-12 17:03 ` tasev.stefanoska
2024-03-12 17:09 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223205851.114931-1-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=enriquezmark36@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kernel@witt.link \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=ricky_wu@realtek.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tasev.stefanoska@skynet.be \
--cc=vidyas@nvidia.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox