From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: Shyam-sundar.S-k@amd.com,
sathyanarayanan.kuppuswamy@linux.intel.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] platform/x86: intel_scu_ipcutil: Make scu static
Date: Mon, 26 Feb 2024 08:39:39 +0200 [thread overview]
Message-ID: <20240226063939.GV8454@black.fi.intel.com> (raw)
In-Reply-To: <20240223163901.13504-3-W_Armin@gmx.de>
On Fri, Feb 23, 2024 at 05:39:01PM +0100, Armin Wolf wrote:
> The variable is only used internally and has no external users,
> so it should me made static.
>
> Compile-tested only.
>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2024-02-26 6:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 16:38 [PATCH v2 1/3] platform/x86/amd/pmf: Add missing __iomem attribute to policy_base Armin Wolf
2024-02-23 16:39 ` [PATCH v2 2/3] platform/x86/amd/pmf: Do not use readl() for policy buffer access Armin Wolf
2024-02-27 12:59 ` Ilpo Järvinen
2024-02-27 13:41 ` Armin Wolf
2024-02-23 16:39 ` [PATCH v2 3/3] platform/x86: intel_scu_ipcutil: Make scu static Armin Wolf
2024-02-26 6:39 ` Mika Westerberg [this message]
2024-02-27 13:06 ` Ilpo Järvinen
2024-02-26 6:41 ` [PATCH v2 1/3] platform/x86/amd/pmf: Add missing __iomem attribute to policy_base Kuppuswamy Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226063939.GV8454@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox