Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free

Lance Yang
2024-02-26T08:55:21Z

Hey David,

Thanks for your suggestion!

On Mon, Feb 26, 2024 at 4:41 PM David Hildenbrand <david@redhat.com> wrote:
>
[...]
> > On Mon, Feb 26, 2024 at 12:00 PM Barry Song <21cnbao@gmail.com> wrote:
> > [...]
> >> On Mon, Feb 26, 2024 at 1:33 AM Lance Yang <ioworker0@gmail.com> wrote:
> > [...]
[...]
> > +static inline bool pte_range_cont_mapped(pte_t *pte, unsigned long nr)
> > +{
> > + pte_t pte_val;
> > + unsigned long pfn = pte_pfn(pte);
> > + for (int i = 0; i < nr; i++) {
> > + pte_val = ptep_get(pte + i);
> > + if (pte_none(pte_val) || pte_pfn(pte_val) != (pfn + i))
> > + return false;
> > + }
> > + return true;
> > +}
>
> I dislike the "cont mapped" terminology.
>
> Maybe folio_pte_batch() does what you want?

folio_pte_batch() is a good choice. Appreciate it!

Best,
Lance

>
> --
> Cheers,
>
> David / dhildenb
>