Re: [PATCH v4] arm64: dts: qcom: sc7280: add slimbus DT node

Manivannan Sadhasivam
2024-02-26T15:41:41Z

On Mon, Feb 19, 2024 at 10:44:55AM +0530, Viken Dadhaniya wrote:
> Populate the DTSI node for slimbus instance to be
> used by bluetooth FM audio case.
>

Just curious, where is the patch to enable bluetooth FM?

> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---
> v3 -> v4:
> - Correct email address for linux-arm-msm.
>
> v2 -> v3:
> - Fix patch title by adding "PATCH" string.
> - Update commit log.
>
> v1 -> v2:
> - change 0x0 -> 0 to reg property.
> - reorder the DT property.
> - change node tag slim_msm to slim.
> ---
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 581818676a4c..1d6afde915aa 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2672,6 +2672,31 @@
> status = "disabled";
> };
>
> + slimbam: dma-controller@3a84000 {
> + compatible = "qcom,bam-v1.7.0";
> + reg = <0 0x03a84000 0 0x20000>;
> + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + qcom,controlled-remotely;
> + num-channels = <31>;
> + qcom,ee = <1>;
> + qcom,num-ees = <2>;
> + iommus = <&apps_smmu 0x1826 0x0>;
> + status = "disabled";
> + };
> +
> + slim: slim-ngd@3ac0000 {
> + compatible = "qcom,slim-ngd-v1.5.0";
> + reg = <0 0x03ac0000 0 0x2c000>;
> + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> + dmas = <&slimbam 3>, <&slimbam 4>;
> + dma-names = "rx", "tx";
> + iommus = <&apps_smmu 0x1826 0x0>;

Does both nodes need IOMMU translation with same SID? This hints that only one
needed.

- Mani

> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> lpass_hm: clock-controller@3c00000 {
> compatible = "qcom,sc7280-lpasshm";
> reg = <0 0x03c00000 0 0x28>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

--
மணிவண்ணன் சதாசிவம்