Re: [PATCH v2 25/31] i2c: fsi: Calculate clock divider from local bus frequency

Andi Shyti
2024-04-15T22:11:08Z

Hi Eddie,

> @@ -689,6 +692,20 @@ static int fsi_i2c_probe(struct device *dev)
> mutex_init(&i2c->lock);
> i2c->fsi = to_fsi_dev(dev);
> INIT_LIST_HEAD(&i2c->ports);
> + i2c->clock_div = I2C_DEFAULT_CLK_DIV;
> +
> + lbus = fsi_device_local_bus_frequency(i2c->fsi);
> + if (lbus) {
> + u32 clock = I2C_DEFAULT_CLK_RATE;

I don't see the need for initialization.

> +
> + if (!device_property_read_u32(dev, "clock-frequency", &clock)) {
> + if (!clock)
> + clock = I2C_DEFAULT_CLK_RATE;
> + }

no need for brackets.

> +
> + // i2c clock rate = local bus clock / (4 * (i2c clock div + 1))

You forgot to remove this.

Andi

> + i2c->clock_div = (((lbus + (clock - 1)) / clock) / 4) - 1;
> + }
>
> rc = fsi_i2c_dev_init(i2c);
> if (rc)
> --
> 2.39.3
>