From: Jonathan Bergh <bergh.jonathan@gmail.com>
To: hdegoede@redhat.com
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jonathan Bergh <bergh.jonathan@gmail.com>
Subject: [PATCH 1/6] staging: media: atomisp: Remove unnecessary braces from single line conditional statements
Date: Mon, 26 Feb 2024 20:40:18 +0100 [thread overview]
Message-ID: <20240226194023.69070-2-bergh.jonathan@gmail.com> (raw)
In-Reply-To: <20240226194023.69070-1-bergh.jonathan@gmail.com>
This patch does the following things:
* Tidies up code in several places where braces were used in conjunction
with single line conditional statements
Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
---
drivers/staging/media/atomisp/pci/sh_css_sp.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c
index cd7f5a3fecaa..23893189ba82 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_sp.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c
@@ -420,9 +420,8 @@ sh_css_copy_buffer_attr_to_spbuffer(struct ia_css_buffer_sp *dest_buf,
lines below. In order to satisfy KW an additional if
has been added. This one will always yield true.
*/
- if ((queue_id < SH_CSS_MAX_NUM_QUEUES)) {
+ if ((queue_id < SH_CSS_MAX_NUM_QUEUES))
dest_buf->buf_src.queue_id = queue_id;
- }
} else {
assert(xmem_addr != mmgr_EXCEPTION);
dest_buf->buf_src.xmem_addr = xmem_addr;
@@ -860,9 +859,8 @@ initialize_isp_states(const struct ia_css_binary *binary)
if (!binary->info->mem_offsets.offsets.state)
return;
- for (i = 0; i < IA_CSS_NUM_STATE_IDS; i++) {
+ for (i = 0; i < IA_CSS_NUM_STATE_IDS; i++)
ia_css_kernel_init_state[i](binary);
- }
}
static void
@@ -878,9 +876,8 @@ initialize_stage_frames(struct ia_css_frames_sp *frames)
unsigned int i;
initialize_frame_buffer_attribute(&frames->in.buf_attr);
- for (i = 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++) {
+ for (i = 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++)
initialize_frame_buffer_attribute(&frames->out[i].buf_attr);
- }
initialize_frame_buffer_attribute(&frames->out_vf.buf_attr);
initialize_frame_buffer_attribute(&frames->s3a_buf);
initialize_frame_buffer_attribute(&frames->dvs_buf);
@@ -1269,9 +1266,8 @@ sh_css_sp_init_pipeline(struct ia_css_pipeline *me,
pipe = find_pipe_by_num(pipe_num);
assert(pipe);
- if (!pipe) {
+ if (!pipe)
return;
- }
sh_css_sp_group.pipe[thread_id].scaler_pp_lut = sh_css_pipe_get_pp_gdc_lut(pipe);
if (md_info && md_info->size > 0) {
--
2.40.1
next prev parent reply other threads:[~2024-02-26 19:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 19:40 [PATCH 0/6] staging: media: atomisp: Fix various small code and code style formatting issues Jonathan Bergh
2024-02-26 19:40 ` Jonathan Bergh [this message]
2024-02-26 19:40 ` [PATCH 2/6] staging: media: atomisp: Fixed "unsigned int *" rather than "unsigned *" declaration in variable declaration Jonathan Bergh
2024-02-26 19:40 ` [PATCH 3/6] staging: media: atomisp: Ensure trailing statements are on a newline and remove spurious whitespaces Jonathan Bergh
2024-02-26 19:40 ` [PATCH 4/6] staging: media: atomisp: Remove unnecessary parentheses from conditional statement Jonathan Bergh
2024-02-26 19:40 ` [PATCH 5/6] staging: media: atomisp: Remove unneeded return statement from void function Jonathan Bergh
2024-02-26 19:40 ` [PATCH 6/6] staging: media: atomisp: Remove old commented code and fix multiple block comment style Jonathan Bergh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226194023.69070-2-bergh.jonathan@gmail.com \
--to=bergh.jonathan@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox