public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Carlos López" <clopez@suse.de>
Cc: cve@kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jonas Gorski <jonas.gorski@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: CVE-2023-52466: PCI: Avoid potential out-of-bounds read in pci_dev_for_each_resource()
Date: Tue, 27 Feb 2024 14:26:26 +0100	[thread overview]
Message-ID: <2024022709-magazine-handshake-50da@gregkh> (raw)
In-Reply-To: <084e7c38-ebce-4091-af40-42283e344ccc@suse.de>

On Tue, Feb 27, 2024 at 02:18:51PM +0100, Carlos López wrote:
> 
> Hi,
> 
> On 25/2/24 9:16, Greg Kroah-Hartman wrote:
> > There is no actual issue right now because we have another check afterwards
> > and the out-of-bounds read is not being performed. In any case it's better
> > code with this fixed, hence the proposed change.
> 
> Given that there is no actual security issue this looks more like a
> hardening, and thus not deserving of a CVE, no?

This was a tricky one, I think it's needed as we do not know how people
are really using these macros, right?  If the PCI maintainer agrees (on
the cc:), I'll be glad to revoke it, it's their call.

And thanks for the review, much appreciated!

greg k-h

  reply	other threads:[~2024-02-27 13:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2024022544-CVE-2023-52466-fea5@gregkh>
2024-02-27 13:18 ` CVE-2023-52466: PCI: Avoid potential out-of-bounds read in pci_dev_for_each_resource() Carlos López
2024-02-27 13:26   ` Greg Kroah-Hartman [this message]
2024-02-27 15:07     ` Bjorn Helgaas
2024-02-27 17:24       ` Greg Kroah-Hartman
2024-02-27 17:39         ` Bjorn Helgaas
2024-02-28  9:20         ` Jiri Kosina
2024-03-03  7:28           ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024022709-magazine-handshake-50da@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=clopez@suse.de \
    --cc=cve@kernel.org \
    --cc=jonas.gorski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox