* [PATCH] platform/x86/fujitsu-laptop: add ACPI_BATTERY dependency
@ 2024-02-28 9:39 Arnd Bergmann
2024-02-29 11:37 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-02-28 9:39 UTC (permalink / raw)
To: Hans de Goede, Ilpo Järvinen, Szilard Fabian,
Jonathan Woithe
Cc: Arnd Bergmann, Andy Shevchenko, platform-driver-x86, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The dependency is required to avoid a link failure after support for
battery hooks was added:
ld.lld: error: undefined symbol: battery_hook_unregister
>>> referenced by fujitsu-laptop.c
>>> drivers/platform/x86/fujitsu-laptop.o:(acpi_fujitsu_laptop_remove) in archive vmlinux.a
Fixes: 611d56d76dee ("platform/x86/fujitsu-laptop: Add battery charge control support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 6dbd40e2aeda..d9851b79bfe5 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -371,6 +371,7 @@ config FUJITSU_LAPTOP
depends on INPUT
depends on BACKLIGHT_CLASS_DEVICE
depends on ACPI_VIDEO || ACPI_VIDEO = n
+ depends on ACPI_BATTERY
select INPUT_SPARSEKMAP
select NEW_LEDS
select LEDS_CLASS
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86/fujitsu-laptop: add ACPI_BATTERY dependency
2024-02-28 9:39 [PATCH] platform/x86/fujitsu-laptop: add ACPI_BATTERY dependency Arnd Bergmann
@ 2024-02-29 11:37 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2024-02-29 11:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Hans de Goede, Szilard Fabian, Jonathan Woithe, Arnd Bergmann,
Andy Shevchenko, platform-driver-x86, LKML
On Wed, 28 Feb 2024, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The dependency is required to avoid a link failure after support for
> battery hooks was added:
>
> ld.lld: error: undefined symbol: battery_hook_unregister
> >>> referenced by fujitsu-laptop.c
> >>> drivers/platform/x86/fujitsu-laptop.o:(acpi_fujitsu_laptop_remove) in archive vmlinux.a
>
> Fixes: 611d56d76dee ("platform/x86/fujitsu-laptop: Add battery charge control support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 6dbd40e2aeda..d9851b79bfe5 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -371,6 +371,7 @@ config FUJITSU_LAPTOP
> depends on INPUT
> depends on BACKLIGHT_CLASS_DEVICE
> depends on ACPI_VIDEO || ACPI_VIDEO = n
> + depends on ACPI_BATTERY
> select INPUT_SPARSEKMAP
> select NEW_LEDS
> select LEDS_CLASS
Thanks. We already fixed this in the originating commit (and now the
fixed version of the commit has also propaged to the for-next branch).
--
i.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-29 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-28 9:39 [PATCH] platform/x86/fujitsu-laptop: add ACPI_BATTERY dependency Arnd Bergmann
2024-02-29 11:37 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox