Re: [PATCH v2 8/9] media: dt-bindings: Add Intel Displayport RX IP

Paweł Anikiel
2024-02-27T13:11:39Z

On Mon, Feb 26, 2024 at 6:29 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/02/2024 13:43, Paweł Anikiel wrote:
> >>>>> + intel,max-stream-count:
> >>>>> + $ref: /schemas/types.yaml#/definitions/uint32
> >>>>> + description: Max stream count configuration parameter
> >>>>> +
> >>>>> + port:
> >>>>> + $ref: /schemas/graph.yaml#/properties/port
> >>>>> + description: SST main link
> >>>>
> >>>> I don't understand why you have both port and ports. Shouldn't this be
> >>>> under ports?
> >>>
> >>> I put both so that you can use the shorter port property when the
> >>> device only has one port (i.e. no MST support). It would work fine
> >>> without it. If you think that's unnecessary, I can remove it (and use
> >>> the ports property even if there is only one).
> >>
> >> No, it is fine, but then you need allOf: which will restrict to only one
> >> of them: either port or ports.
> >
> > There already is an allOf below that says that ports is required for
> > MST support and port is required otherwise. Isn't this enough?
>
> Add both port and ports and see if it is enough.

Ok, I see. I tried and this seems to work:

oneOf:
- required:
- port
- required:
- ports

And that would make the if/else with port and ports below not needed.
What do you think?