public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Guan-Yu Lin <guanyulin@google.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	rafael@kernel.org, pavel@ucw.cz, len.brown@intel.com,
	andriy.shevchenko@linux.intel.com, rdunlap@infradead.org,
	james@equiv.tech, broonie@kernel.org, james.clark@arm.com,
	masahiroy@kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v3] PM / core: conditionally skip system pm in device/driver model
Date: Thu, 29 Feb 2024 21:34:26 +0100	[thread overview]
Message-ID: <2024022901-getaway-bacon-b805@gregkh> (raw)
In-Reply-To: <CAOuDEK2OtAO7GqPzWkdC=SARkuHYGzqW4iPdFfMx8dyw4Cy+Lg@mail.gmail.com>

On Thu, Feb 29, 2024 at 05:08:00PM +0800, Guan-Yu Lin wrote:
> We want to introduce a mechanism that allows the Linux kernel to make
> power transitions for the peripheral based on whether the other
> operating system kernel is actively using it. To achieve this, we
> propose this patch that adds a sysfs attribute, providing the Linux
> kernel with the necessary information.

Don't create random user/kernel apis in sysfs for no good reason just
because it is "easy" :(

If the "other operating system is actively using it" isn't able to be
detected by Linux, then Linux shouldn't be able to change the PM state,
so this sounds like you need to fix your Linux driver to properly know
this information, just like any other device type (think about a sound
device that needs to know if it is being used or not, nothing different
here.)

So please post your Linux driver and we can see what needs to be done
there to get this to work properly, odds are you are just missing
something.  Have a pointer to the code anywhere?

Also, as you know, we can NOT add interfaces to the kernel without any
real user, so without a driver for your hardware, none of this is able
to go anywhere at all, sorry.

thanks,

greg k-h

  reply	other threads:[~2024-02-29 20:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 14:38 [PATCH v3] PM / core: conditionally skip system pm in device/driver model Guan-Yu Lin
2024-02-23 15:18 ` Andy Shevchenko
2024-02-26  9:15   ` Guan-Yu Lin
2024-02-26 14:02     ` Andy Shevchenko
2024-02-27  6:47       ` Guan-Yu Lin
2024-02-23 17:43 ` Rafael J. Wysocki
2024-02-26  9:45   ` Guan-Yu Lin
2024-02-27 11:28     ` Rafael J. Wysocki
2024-02-29 10:09       ` Guan-Yu Lin
2024-02-23 18:20 ` Florian Fainelli
2024-02-26 10:28   ` Guan-Yu Lin
2024-02-26 18:40     ` Florian Fainelli
2024-02-27  8:56       ` Guan-Yu Lin
2024-02-27  9:15         ` Greg KH
2024-02-29 10:27           ` Guan-Yu Lin
2024-02-27 17:57         ` Florian Fainelli
2024-02-29  9:08           ` Guan-Yu Lin
2024-02-29 20:34             ` Greg KH [this message]
2024-03-08 18:04               ` Guan-Yu Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024022901-getaway-bacon-b805@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=guanyulin@google.com \
    --cc=james.clark@arm.com \
    --cc=james@equiv.tech \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox