From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] kconfig: add some Kconfig env variables to make help
Date: Thu, 29 Feb 2024 11:10:10 +0900 [thread overview]
Message-ID: <20240229021010.GM11972@google.com> (raw)
In-Reply-To: <CAK7LNAQ8OyNMeGzVoTRg-sHDZ4YK0EKY_eEWNepekaibO_ZKwg@mail.gmail.com>
On (24/02/29 11:03), Masahiro Yamada wrote:
> > > > > +++ b/scripts/kconfig/Makefile
> > > > > @@ -158,6 +158,10 @@ help:
> > > > > if help=$$(grep -m1 '^# Help: ' $(f)); then \
> > > > > printf ' %-25s - %s\n' '$(notdir $(f))' "$${help#*: }"; \
> > > > > fi;)
> > > > > + @echo ''
> > > > > + @echo 'Configuration environment variables:'
> > > > > + @echo ' KCONFIG_WERROR - Turn some Kconfig warnings into error conditions'
> > > > > + @echo ' KCONFIG_WARN_UNKNOWN_SYMBOLS - Make Kconfig warn about all unrecognized config symbols'
> > > > >
> > > > > # ===========================================================================
> > > > > # object files used by all kconfig flavours
> > > > > --
> > > > > 2.44.0.rc0.258.g7320e95886-goog
> > > > >
> > > > >
> > > >
> > > > Why only two, while Kconfig supports more env variables?
> > >
> > > Right. I wanted to add only those that we use (and familiar with) for
> > > starters. I'm not familiar with things like KCONFIG_PROBABILITY, for
> > > instance, and not sure how to document it (its Documentation/kbuild/kconfig.rst
> > > description is pretty lengthy).
> >
> > Masahiro, any opinion?
>
>
> I do not need this patch.
Do you agree that putting kconfig env knobs into help makes sense
in general? Especially those add valuable sanity checks.
next prev parent reply other threads:[~2024-02-29 2:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 3:12 [PATCH] kconfig: add some Kconfig env variables to make help Sergey Senozhatsky
2024-02-22 3:18 ` Sergey Senozhatsky
2024-02-22 3:25 ` [PATCHv2] " Sergey Senozhatsky
2024-02-22 4:57 ` Masahiro Yamada
2024-02-22 5:16 ` Sergey Senozhatsky
2024-02-28 4:56 ` Sergey Senozhatsky
2024-02-29 2:03 ` Masahiro Yamada
2024-02-29 2:10 ` Sergey Senozhatsky [this message]
2024-02-29 3:36 ` Masahiro Yamada
2024-02-29 3:47 ` Sergey Senozhatsky
2024-02-29 15:35 ` Masahiro Yamada
2024-03-01 4:33 ` Sergey Senozhatsky
2024-03-01 11:04 ` Nicolas Schier
2024-03-01 14:28 ` Sergey Senozhatsky
2024-03-04 6:41 ` Nicolas Schier
2024-03-05 16:46 ` Masahiro Yamada
2024-03-09 20:24 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229021010.GM11972@google.com \
--to=senozhatsky@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox