From: Luis Henriques <lhenriques@suse.de>
To: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Henriques <lhenriques@suse.de>
Subject: [PATCH 3/3] overlay: fix mount parameters check for empty values
Date: Thu, 29 Feb 2024 16:30:10 +0000 [thread overview]
Message-ID: <20240229163011.16248-4-lhenriques@suse.de> (raw)
In-Reply-To: <20240229163011.16248-1-lhenriques@suse.de>
Now that parameters that have the flag 'fs_param_can_be_empty' set and
their value is NULL are handled as 'flag' type, we need to properly check
for empty (NULL) values.
Signed-off-by: Luis Henriques <lhenriques@suse.de>
---
fs/overlayfs/params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
index 112b4b12f825..09428af6abc5 100644
--- a/fs/overlayfs/params.c
+++ b/fs/overlayfs/params.c
@@ -441,7 +441,7 @@ static int ovl_parse_param_lowerdir(const char *name, struct fs_context *fc)
/* drop all existing lower layers */
ovl_reset_lowerdirs(ctx);
- if (!*name)
+ if (!name)
return 0;
if (*name == ':') {
next prev parent reply other threads:[~2024-02-29 16:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 16:30 [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value Luis Henriques
2024-02-29 16:30 ` [PATCH 1/3] " Luis Henriques
2024-03-01 13:31 ` Christian Brauner
2024-03-01 15:45 ` Luis Henriques
2024-03-02 11:46 ` Christian Brauner
2024-03-02 17:56 ` Christian Brauner
2024-03-03 21:31 ` Luis Henriques
2024-03-04 9:04 ` Christian Brauner
2024-03-03 21:17 ` Luis Henriques
2024-03-07 15:13 ` Jan Kara
2024-03-08 9:53 ` Christian Brauner
2024-03-08 10:12 ` Luis Henriques
2024-03-08 23:09 ` Jan Kara
2024-03-11 10:26 ` Luis Henriques
2024-03-11 16:01 ` Jan Kara
2024-02-29 16:30 ` [PATCH 2/3] ext4: fix mount parameters check for empty values Luis Henriques
2024-03-01 13:36 ` Christian Brauner
2024-03-01 15:47 ` Luis Henriques
2024-02-29 16:30 ` Luis Henriques [this message]
2024-03-01 13:37 ` [PATCH 3/3] overlay: " Christian Brauner
2024-03-01 13:12 ` [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value Christian Brauner
2024-03-01 14:54 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229163011.16248-4-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=adilger.kernel@dilger.ca \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox