From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Swapnil Patel <swapnil.patel@amd.com>,
Charlene Liu <charlene.liu@amd.com>,
Rodrigo Siqueira <rodrigo.siqueira@amd.com>,
Daniel Wheeler <daniel.wheeler@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Sasha Levin <sashal@kernel.org>,
harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
nicholas.kazlauskas@amd.com, hamza.mahfooz@amd.com,
roman.li@amd.com, syed.hassan@amd.com, sungkim@amd.com,
jerry.zuo@amd.com, Qingqing.Zhuo@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 6.7 24/24] drm/amd/display: fix input states translation error for dcn35 & dcn351
Date: Thu, 29 Feb 2024 15:37:04 -0500 [thread overview]
Message-ID: <20240229203729.2860356-24-sashal@kernel.org> (raw)
In-Reply-To: <20240229203729.2860356-1-sashal@kernel.org>
From: Swapnil Patel <swapnil.patel@amd.com>
[ Upstream commit 27a6c49394b1a203beeb94752c9a1d6318f24ddf ]
[Why]
Currently there is an error while translating input clock sates into
output clock states. The highest fclk setting from output sates is
being dropped because of this error.
[How]
For dcn35 and dcn351, make output_states equal to input states.
Reviewed-by: Charlene Liu <charlene.liu@amd.com>
Acked-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Swapnil Patel <swapnil.patel@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
.../drm/amd/display/dc/dml2/dml2_translation_helper.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
index 2c379be19aa84..16452dae4acac 100644
--- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
+++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
@@ -398,7 +398,6 @@ void dml2_init_soc_states(struct dml2_context *dml2, const struct dc *in_dc,
/* Copy clocks tables entries, if available */
if (dml2->config.bbox_overrides.clks_table.num_states) {
p->in_states->num_states = dml2->config.bbox_overrides.clks_table.num_states;
-
for (i = 0; i < dml2->config.bbox_overrides.clks_table.num_entries_per_clk.num_dcfclk_levels; i++) {
p->in_states->state_array[i].dcfclk_mhz = dml2->config.bbox_overrides.clks_table.clk_entries[i].dcfclk_mhz;
}
@@ -437,6 +436,14 @@ void dml2_init_soc_states(struct dml2_context *dml2, const struct dc *in_dc,
}
dml2_policy_build_synthetic_soc_states(s, p);
+ if (dml2->v20.dml_core_ctx.project == dml_project_dcn35 ||
+ dml2->v20.dml_core_ctx.project == dml_project_dcn351) {
+ // Override last out_state with data from last in_state
+ // This will ensure that out_state contains max fclk
+ memcpy(&p->out_states->state_array[p->out_states->num_states - 1],
+ &p->in_states->state_array[p->in_states->num_states - 1],
+ sizeof(struct soc_state_bounding_box_st));
+ }
}
void dml2_translate_ip_params(const struct dc *in, struct ip_params_st *out)
--
2.43.0
prev parent reply other threads:[~2024-02-29 20:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 20:36 [PATCH AUTOSEL 6.7 01/24] soc: microchip: Fix POLARFIRE_SOC_SYS_CTRL input prompt Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 02/24] arm64: dts: rockchip: mark system power controller on rk3588-evb1 Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 03/24] RDMA/mlx5: Fix fortify source warning while accessing Eth segment Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 04/24] RDMA/mlx5: Relax DEVX access upon modify commands Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 05/24] ARM: dts: rockchip: Drop interrupts property from pwm-rockchip nodes Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 06/24] bpf: Fix warning for bpf_cpumask in verifier Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 07/24] riscv: dts: sifive: add missing #interrupt-cells to pmic Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 08/24] x86/mm: Move is_vsyscall_vaddr() into asm/vsyscall.h Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 09/24] x86/mm: Disallow vsyscall page read for copy_from_kernel_nofault() Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 10/24] net/iucv: fix the allocation size of iucv_path_table array Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 11/24] parisc/ftrace: add missing CONFIG_DYNAMIC_FTRACE check Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 12/24] block: sed-opal: handle empty atoms when parsing response Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 13/24] cxl/region: Handle endpoint decoders in cxl_region_find_decoder() Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 14/24] cxl/region: Allow out of order assembly of autodiscovered regions Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 15/24] enic: Avoid false positive under FORTIFY_SOURCE Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 16/24] perf: CXL: fix CPMU filter value mask length Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 17/24] platform/x86: x86-android-tablets: Fix acer_b1_750_goodix_gpios name Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 18/24] dm-verity, dm-crypt: align "struct bvec_iter" correctly Sasha Levin
2024-02-29 20:36 ` [PATCH AUTOSEL 6.7 19/24] arm: dts: Fix dtc interrupt_provider warnings Sasha Levin
2024-02-29 20:37 ` [PATCH AUTOSEL 6.7 20/24] arm64: " Sasha Levin
2024-02-29 20:37 ` [PATCH AUTOSEL 6.7 21/24] arm: dts: Fix dtc interrupt_map warnings Sasha Levin
2024-02-29 20:37 ` [PATCH AUTOSEL 6.7 22/24] arm64: dts: qcom: Fix interrupt-map cell sizes Sasha Levin
2024-02-29 20:37 ` [PATCH AUTOSEL 6.7 23/24] ARM: dts: renesas: rcar-gen2: Add missing #interrupt-cells to DA9063 nodes Sasha Levin
2024-02-29 20:37 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229203729.2860356-24-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Qingqing.Zhuo@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=charlene.liu@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel.wheeler@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamza.mahfooz@amd.com \
--cc=harry.wentland@amd.com \
--cc=jerry.zuo@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicholas.kazlauskas@amd.com \
--cc=rodrigo.siqueira@amd.com \
--cc=roman.li@amd.com \
--cc=stable@vger.kernel.org \
--cc=sungkim@amd.com \
--cc=sunpeng.li@amd.com \
--cc=swapnil.patel@amd.com \
--cc=syed.hassan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox